mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qapi: Add minor typing workaround for 3.6

Browse Source 
Pylint under 3.6 does not believe that Collection is subscriptable at
runtime. It is, making this a Pylint
bug. https://github.com/PyCQA/pylint/issues/2377

They closed it as fixed, but that doesn't seem to be true as of Pylint
2.13.9, the latest version you can install under Python 3.6. 2.13.9 was
released 2022-05-13, about seven months after the bug was closed.

The least-annoying fix here is to just use the concret type.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20230215000011.1725012-4-jsnow@redhat.com>
[Dumbed down from Sequence[str] to List[str], commit message adjusted]
Reviewed-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
John Snow 2023-02-14 19:00:08 -05:00 committed by Markus Armbruster
parent 885ecdbec9
commit c60caf8086
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/qapi/expr.py
View File

@ -33,7 +33,6 @@ structures and contextual semantic validation.
import re
from typing import (
Collection,
Dict,
Iterable,
List,
@ -195,8 +194,8 @@ def check_defn_name_str(name: str, info: QAPISourceInfo, meta: str) -> None:
def check_keys(value: _JSONObject,
info: QAPISourceInfo,
source: str,
required: Collection[str],
optional: Collection[str]) -> None:
required: List[str],
optional: List[str]) -> None:
"""
Ensure that a dict has a specific set of keys.