mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

disas/microblaze: Replace sprintf() by snprintf()

Browse Source 
sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
resulting in painful developper experience. Use snprintf() instead.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Message-Id: <20240411104340.6617-3-philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2024-04-11 12:32:14 +02:00
parent 28d5bfc098
commit c54c6a1088
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
disas/microblaze.c
View File

@ -600,7 +600,8 @@ static char *
get_field (long instr, long mask, unsigned short low) get_field (long instr, long mask, unsigned short low)
{ {
char tmpstr[25]; char tmpstr[25];
sprintf(tmpstr, "%s%d", register_prefix, (int)((instr & mask) >> low)); snprintf(tmpstr, sizeof(tmpstr), "%s%d", register_prefix,
(int)((instr & mask) >> low));
return(strdup(tmpstr)); return(strdup(tmpstr));
} }
@ -608,7 +609,8 @@ static char *
get_field_imm (long instr) get_field_imm (long instr)
{ {
char tmpstr[25]; char tmpstr[25];
sprintf(tmpstr, "%d", (short)((instr & IMM_MASK) >> IMM_LOW)); snprintf(tmpstr, sizeof(tmpstr), "%d",
(short)((instr & IMM_MASK) >> IMM_LOW));
return(strdup(tmpstr)); return(strdup(tmpstr));
} }
@ -616,7 +618,8 @@ static char *
get_field_imm5 (long instr) get_field_imm5 (long instr)
{ {
char tmpstr[25]; char tmpstr[25];
sprintf(tmpstr, "%d", (short)((instr & IMM5_MASK) >> IMM_LOW)); snprintf(tmpstr, sizeof(tmpstr), "%d",
(short)((instr & IMM5_MASK) >> IMM_LOW));
return(strdup(tmpstr)); return(strdup(tmpstr));
} }
@ -624,7 +627,8 @@ static char *
get_field_rfsl (long instr) get_field_rfsl (long instr)
{ {
char tmpstr[25]; char tmpstr[25];
sprintf(tmpstr, "%s%d", fsl_register_prefix, (short)((instr & RFSL_MASK) >> IMM_LOW)); snprintf(tmpstr, sizeof(tmpstr), "%s%d", fsl_register_prefix,
(short)((instr & RFSL_MASK) >> IMM_LOW));
return(strdup(tmpstr)); return(strdup(tmpstr));
} }
@ -632,7 +636,8 @@ static char *
get_field_imm15 (long instr) get_field_imm15 (long instr)
{ {
char tmpstr[25]; char tmpstr[25];
sprintf(tmpstr, "%d", (short)((instr & IMM15_MASK) >> IMM_LOW)); snprintf(tmpstr, sizeof(tmpstr), "%d",
(short)((instr & IMM15_MASK) >> IMM_LOW));
return(strdup(tmpstr)); return(strdup(tmpstr));
} }
@ -641,7 +646,8 @@ static char *
get_field_unsigned_imm (long instr) get_field_unsigned_imm (long instr)
{ {
char tmpstr[25]; char tmpstr[25];
sprintf(tmpstr, "%d", (int)((instr & IMM_MASK) >> IMM_LOW)); snprintf(tmpstr, sizeof(tmpstr), "%d",
(int)((instr & IMM_MASK) >> IMM_LOW));
return(strdup(tmpstr)); return(strdup(tmpstr));
} }
#endif #endif
@ -653,7 +659,8 @@ get_field_unsigned_imm (long instr)
{ {
char tmpstr[25]; char tmpstr[25];
sprintf(tmpstr, "%s%s", register_prefix, (((instr & IMM_MASK) >> IMM_LOW) & REG_MSR_MASK) == 0 ? "pc" : "msr"); snprintf(tmpstr, sizeof(tmpstr), "%s%s", register_prefix,
(((instr & IMM_MASK) >> IMM_LOW) & REG_MSR_MASK) == 0 ? "pc" : "msr");
return(strdup(tmpstr)); return(strdup(tmpstr));
} }
@ -709,7 +716,7 @@ get_field_special(long instr, const struct op_code_struct *op)
default : default :
{ {
if ( ((((instr & IMM_MASK) >> IMM_LOW) ^ op->immval_mask) & 0xE000) == REG_PVR_MASK) { if ( ((((instr & IMM_MASK) >> IMM_LOW) ^ op->immval_mask) & 0xE000) == REG_PVR_MASK) {
sprintf(tmpstr, "%s%u", pvr_register_prefix, snprintf(tmpstr, sizeof(tmpstr), "%s%u", pvr_register_prefix,
(unsigned short)(((instr & IMM_MASK) >> IMM_LOW) ^ (unsigned short)(((instr & IMM_MASK) >> IMM_LOW) ^
op->immval_mask) ^ REG_PVR_MASK); op->immval_mask) ^ REG_PVR_MASK);
return(strdup(tmpstr)); return(strdup(tmpstr));
@ -720,7 +727,7 @@ get_field_special(long instr, const struct op_code_struct *op)
break; break;
} }
sprintf(tmpstr, "%s%s", register_prefix, spr); snprintf(tmpstr, sizeof(tmpstr), "%s%s", register_prefix, spr);
return(strdup(tmpstr)); return(strdup(tmpstr));
} }