nbd: Silence Coverity false positive
Coverity noticed (CID 1436125) that we check the return value of nbd_extent_array_add in most places, but not at the end of bitmap_to_extents(). The return value exists to break loops before a future iteration, so there is nothing to check if we are already done iterating. Adding a cast to void, plus a comment why, pacifies Coverity. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20201111163510.713855-1-eblake@redhat.com> [eblake: Prefer cast to void over odd && usage] Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
parent
cb5ed407a1
commit
c0b21f2e22
@ -2129,8 +2129,8 @@ static void bitmap_to_extents(BdrvDirtyBitmap *bitmap,
|
||||
}
|
||||
|
||||
if (!full) {
|
||||
/* last non dirty extent */
|
||||
nbd_extent_array_add(es, end - start, 0);
|
||||
/* last non dirty extent, nothing to do if array is now full */
|
||||
(void) nbd_extent_array_add(es, end - start, 0);
|
||||
}
|
||||
|
||||
bdrv_dirty_bitmap_unlock(bitmap);
|
||||
|
Loading…
Reference in New Issue
Block a user