mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libcacard: Fix unchecked strdup() by converting to g_strdup()

Browse Source 
Note that we already free with g_free().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Markus Armbruster 2013-01-22 11:08:04 +01:00 committed by Stefan Hajnoczi
parent 40a50b0a73
commit be168af860
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libcacard/vcard_emul_nss.c
View File

@ -454,7 +454,7 @@ vreader_emul_new(PK11SlotInfo *slot, VCardEmulType type, const char *params)
new_reader_emul->slot = PK11_ReferenceSlot(slot); new_reader_emul->slot = PK11_ReferenceSlot(slot);
new_reader_emul->default_type = type; new_reader_emul->default_type = type;
new_reader_emul->type_params = strdup(params); new_reader_emul->type_params = g_strdup(params);
new_reader_emul->present = PR_FALSE; new_reader_emul->present = PR_FALSE;
new_reader_emul->series = 0; new_reader_emul->series = 0;
new_reader_emul->saved_vcard = NULL; new_reader_emul->saved_vcard = NULL;
@ -997,7 +997,7 @@ vcard_emul_init(const VCardEmulOptions *options)
/* We should control this with options. For now we mirror out any /* We should control this with options. For now we mirror out any
* removable hardware slot */ * removable hardware slot */
default_card_type = options->hw_card_type; default_card_type = options->hw_card_type;
default_type_params = strdup(options->hw_type_params); default_type_params = g_strdup(options->hw_type_params);
SECMOD_GetReadLock(module_lock); SECMOD_GetReadLock(module_lock);
for (mlp = module_list; mlp; mlp = mlp->next) { for (mlp = module_list; mlp; mlp = mlp->next) {

2
libcacard/vreader.c
View File

@ -49,7 +49,7 @@ vreader_new(const char *name, VReaderEmul *private,
reader = (VReader *)g_malloc(sizeof(VReader)); reader = (VReader *)g_malloc(sizeof(VReader));
qemu_mutex_init(&reader->lock); qemu_mutex_init(&reader->lock);
reader->reference_count = 1; reader->reference_count = 1;
reader->name = name ? strdup(name) : NULL; reader->name = g_strdup(name);
reader->card = NULL; reader->card = NULL;
reader->id = (vreader_id_t)-1; reader->id = (vreader_id_t)-1;
reader->reader_private = private; reader->reader_private = private;

4
libcacard/vscclient.c
View File

@ -503,8 +503,8 @@ main(
command_line_options = vcard_emul_options(emul_args); command_line_options = vcard_emul_options(emul_args);
} }
qemu_host = strdup(argv[argc - 2]); qemu_host = g_strdup(argv[argc - 2]);
qemu_port = strdup(argv[argc - 1]); qemu_port = g_strdup(argv[argc - 1]);
sock = connect_to_qemu(qemu_host, qemu_port); sock = connect_to_qemu(qemu_host, qemu_port);
if (sock == -1) { if (sock == -1) {
fprintf(stderr, "error opening socket, exiting.\n"); fprintf(stderr, "error opening socket, exiting.\n");