mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "usb-hub: report status changes only once"

Browse Source 
This reverts commit a309ee6e0a.

This isn't in line with the usb specification and adds regressions,
win7 fails to drive the usb hub for example.

Was added because it "solved" the issue of hubs interacting badly
with the xhci host controller.  Now with the root cause being fixed
in xhci (commit <FIXME>) we can revert this one.

Cc: qemu-stable@nongnu.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Gerd Hoffmann 2013-08-27 17:00:04 +02:00
parent b8cbc1374a
commit bdebd6ee81
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/usb/dev-hub.c
View File

@ -33,7 +33,6 @@ typedef struct USBHubPort {
USBPort port; USBPort port;
uint16_t wPortStatus; uint16_t wPortStatus;
uint16_t wPortChange; uint16_t wPortChange;
uint16_t wPortChange_reported;
} USBHubPort; } USBHubPort;
typedef struct USBHubState { typedef struct USBHubState {
@ -468,11 +467,8 @@ static void usb_hub_handle_data(USBDevice *dev, USBPacket *p)
status = 0; status = 0;
for(i = 0; i < NUM_PORTS; i++) { for(i = 0; i < NUM_PORTS; i++) {
port = &s->ports[i]; port = &s->ports[i];
if (port->wPortChange && if (port->wPortChange)
port->wPortChange_reported != port->wPortChange) {
status |= (1 << (i + 1)); status |= (1 << (i + 1));
}
port->wPortChange_reported = port->wPortChange;
} }
if (status != 0) { if (status != 0) {
trace_usb_hub_status_report(s->dev.addr, status); trace_usb_hub_status_report(s->dev.addr, status);