mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qapi: Fix build_params() for empty parameter list

Browse Source 
build_params() returns '' instead of 'void' when there are no
parameters.  Can't happen now, but the next commit will change that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
[peterx: compose the patch from email replies]
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20180815133747.25032-3-peterx@redhat.com>
This commit is contained in:
Markus Armbruster 2018-08-15 21:37:36 +08:00
parent 19b599f766
commit bdd2d42b89
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/qapi/common.py
View File

@ -2070,16 +2070,14 @@ extern const QEnumLookup %(c_name)s_lookup;
return ret
def build_params(arg_type, boxed, extra):
if not arg_type:
assert not boxed
return extra
def build_params(arg_type, boxed, extra=None):
ret = ''
sep = ''
if boxed:
assert arg_type
ret += '%s arg' % arg_type.c_param_type()
sep = ', '
else:
elif arg_type:
assert not arg_type.variants
for memb in arg_type.members:
ret += sep
@ -2090,7 +2088,7 @@ def build_params(arg_type, boxed, extra):
c_name(memb.name))
if extra:
ret += sep + extra
return ret
return ret if ret else 'void'
#