mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qapi/expr.py: Remove 'info' argument from nested check_if_str

Browse Source 
The function can just use the argument from the scope above. Otherwise,
we get shadowed argument errors because the parameter name clashes with
the name of a variable already in-scope.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210421182032.3521476-3-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
John Snow 2021-04-21 14:20:17 -04:00 committed by Markus Armbruster
parent d0a263cdd0
commit b7341b89c9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/qapi/expr.py
View File

@ -122,7 +122,7 @@ def check_flags(expr, info):
def check_if(expr, info, source):
def check_if_str(ifcond, info):
def check_if_str(ifcond):
if not isinstance(ifcond, str):
raise QAPISemError(
info,
@ -142,9 +142,9 @@ def check_if(expr, info, source):
raise QAPISemError(
info, "'if' condition [] of %s is useless" % source)
for elt in ifcond:
check_if_str(elt, info)
check_if_str(elt)
else:
check_if_str(ifcond, info)
check_if_str(ifcond)
expr['if'] = [ifcond]