mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/i386: Remove x86_cpu_dump_local_apic_state() dead stub

Browse Source 
x86_cpu_dump_local_apic_state() is called from monitor.c which
is only compiled for system emulation since commit bf95728400
("monitor: remove target-specific code from monitor.c").

Interestingly this stub was added few weeks later in commit
1f871d49e3 ("hmp: added local apic dump state") and was not
necessary by that time.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20221216220158.6317-5-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2022-12-16 13:39:32 +01:00
parent dd20414f9a
commit b5c6a3c1df
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
target/i386/cpu-dump.c
View File

@ -335,10 +335,7 @@ void x86_cpu_dump_local_apic_state(CPUState *cs, int flags)
} }
qemu_printf(" PPR 0x%02x\n", apic_get_ppr(s)); qemu_printf(" PPR 0x%02x\n", apic_get_ppr(s));
} }
#else
void x86_cpu_dump_local_apic_state(CPUState *cs, int flags)
{
}
#endif /* !CONFIG_USER_ONLY */ #endif /* !CONFIG_USER_ONLY */
#define DUMP_CODE_BYTES_TOTAL 50 #define DUMP_CODE_BYTES_TOTAL 50

4
target/i386/cpu.h
View File

@ -2355,12 +2355,16 @@ typedef int X86CPUVersion;
*/ */
void x86_cpu_set_default_version(X86CPUVersion version); void x86_cpu_set_default_version(X86CPUVersion version);
#ifndef CONFIG_USER_ONLY
#define APIC_DEFAULT_ADDRESS 0xfee00000 #define APIC_DEFAULT_ADDRESS 0xfee00000
#define APIC_SPACE_SIZE 0x100000 #define APIC_SPACE_SIZE 0x100000
/* cpu-dump.c */ /* cpu-dump.c */
void x86_cpu_dump_local_apic_state(CPUState *cs, int flags); void x86_cpu_dump_local_apic_state(CPUState *cs, int flags);
#endif
/* cpu.c */ /* cpu.c */
bool cpu_is_bsp(X86CPU *cpu); bool cpu_is_bsp(X86CPU *cpu);