mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sheepdog: Remove unnecessary NULL check in sd_prealloc()

Browse Source 
In commit 8b9ad56e9cbfd852a, we removed the code that could result
in our getting to sd_prealloc()'s out_with_err_set label with a
NULL blk pointer. That makes the NULL check in the error-handling
path unnecessary, and Coverity gripes about it (CID 1390636).
Delete the redundant check.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Peter Maydell 2018-05-18 19:17:17 +01:00 committed by Kevin Wolf
parent 4e24ed138b
commit ae8622ec19
1 changed files with 1 additions and 3 deletions

4
block/sheepdog.c

@ -1859,9 +1859,7 @@ out:
error_setg_errno(errp, -ret, "Can't pre-allocate"); error_setg_errno(errp, -ret, "Can't pre-allocate");
} }
out_with_err_set: out_with_err_set:
if (blk) { blk_unref(blk);
blk_unref(blk);
}
g_free(buf); g_free(buf);
return ret; return ret;