mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid cpu_physical_memory_rw() with a constant is_write argument

Browse Source 
This commit was produced with the included Coccinelle script
scripts/coccinelle/exec_rw_const.

Inspired-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This commit is contained in:
Philippe Mathieu-Daudé 2020-02-19 20:34:58 +01:00
parent 85eb7c18ee
commit adeefe0167
3 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/xen/xen_pt_graphics.c
View File

@ -222,7 +222,7 @@ void xen_pt_setup_vga(XenPCIPassthroughState *s, XenHostPCIDevice *dev,
} }
/* Currently we fixed this address as a primary for legacy BIOS. */ /* Currently we fixed this address as a primary for legacy BIOS. */
cpu_physical_memory_rw(0xc0000, bios, bios_size, true); cpu_physical_memory_write(0xc0000, bios, bios_size);
} }
uint32_t igd_read_opregion(XenPCIPassthroughState *s) uint32_t igd_read_opregion(XenPCIPassthroughState *s)

12
scripts/coccinelle/exec_rw_const.cocci
View File

@ -62,6 +62,18 @@ symbol true, false;
+ address_space_write(E1, E2, E3, E4, E5) + address_space_write(E1, E2, E3, E4, E5)
) )
// Avoid uses of cpu_physical_memory_rw() with a constant is_write argument.
@@
expression E1, E2, E3;
@@
(
- cpu_physical_memory_rw(E1, E2, E3, false)
+ cpu_physical_memory_read(E1, E2, E3)
|
- cpu_physical_memory_rw(E1, E2, E3, true)
+ cpu_physical_memory_write(E1, E2, E3)
)
// Remove useless cast // Remove useless cast
@@ @@
expression E1, E2, E3, E4, E5, E6; expression E1, E2, E3, E4, E5, E6;

4
target/i386/hax-all.c
View File

@ -376,8 +376,8 @@ static int hax_handle_fastmmio(CPUArchState *env, struct hax_fastmmio *hft)
* hft->direction == 2: gpa ==> gpa2 * hft->direction == 2: gpa ==> gpa2
*/ */
uint64_t value; uint64_t value;
cpu_physical_memory_rw(hft->gpa, &value, hft->size, false); cpu_physical_memory_read(hft->gpa, &value, hft->size);
cpu_physical_memory_rw(hft->gpa2, &value, hft->size, true); cpu_physical_memory_write(hft->gpa2, &value, hft->size);
} }
return 0; return 0;