mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/m68k: Initialize float_status fields in gdb set/get functions

Browse Source 
In cf_fpu_gdb_get_reg() and cf_fpu_gdb_set_reg() we use a temporary
float_status variable to pass to floatx80_to_float64() and
float64_to_floatx80(), but we don't initialize it, meaning that those
functions could access uninitialized data.  Zero-init the structs.

(We don't need to set a NaN-propagation rule here because we
don't use these with a 2-argument fpu operation.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20241025141254.2141506-11-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2024-11-05 10:09:54 +00:00
parent 0527cfd94c
commit ad58ba13d0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
target/m68k/helper.c
View File

@ -36,7 +36,7 @@ static int cf_fpu_gdb_get_reg(CPUState *cs, GByteArray *mem_buf, int n)
CPUM68KState *env = &cpu->env; CPUM68KState *env = &cpu->env;
if (n < 8) { if (n < 8) {
float_status s; float_status s = {};
return gdb_get_reg64(mem_buf, floatx80_to_float64(env->fregs[n].d, &s)); return gdb_get_reg64(mem_buf, floatx80_to_float64(env->fregs[n].d, &s));
} }
switch (n) { switch (n) {
@ -56,7 +56,7 @@ static int cf_fpu_gdb_set_reg(CPUState *cs, uint8_t *mem_buf, int n)
CPUM68KState *env = &cpu->env; CPUM68KState *env = &cpu->env;
if (n < 8) { if (n < 8) {
float_status s; float_status s = {};
env->fregs[n].d = float64_to_floatx80(ldq_be_p(mem_buf), &s); env->fregs[n].d = float64_to_floatx80(ldq_be_p(mem_buf), &s);
return 8; return 8;
} }