mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qapi/error: assert QAPISourceInfo is not None

Browse Source 
Built-in stuff is not parsed from a source file, and therefore have no
QAPISourceInfo. If such None info was used for reporting an error,
built-in stuff would be broken. Programming error. Instead of reporting
a confusing error with bogus source location then, we better crash.

We currently crash only if self.col was set. Assert that self.info is
not None in order to crash reliably.

We can not yet change the type of the initializer to prove this cannot
happen at static analysis time before the remainder of the code is fully
typed.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210421192233.3542904-5-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
John Snow 2021-04-21 15:22:29 -04:00 committed by Markus Armbruster
parent 86cc2ff65a
commit ac89761179
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
scripts/qapi/error.py
View File

@ -25,6 +25,7 @@ class QAPISourceError(QAPIError):
self.col = col self.col = col
def __str__(self): def __str__(self):
assert self.info is not None
loc = str(self.info) loc = str(self.info)
if self.col is not None: if self.col is not None:
assert self.info.line is not None assert self.info.line is not None