mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qom: Plug memory leak in "info qom-tree"

Browse Source 
Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted"
created a memory leak, because I didn't realize
object_get_canonical_path_component()'s value needs to be freed.

Reproducer:

    $ qemu-system-x86_64 -nodefaults -display none -S -monitor stdio
    QEMU 5.0.50 monitor - type 'help' for more information
    (qemu) info qom-tree

This leaks some 4500 path components, 12-13 characters on average,
i.e. roughly 100kBytes depending on the allocator.  A couple of
hundred "info qom-tree" here, a couple of hundred there, and soon
enough we're talking about real memory.

Plug the leak.

Fixes: e8c9e65816
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reported-by: Reviewed-by: Li Qiang <liq3ea@gmail.com> [sent same patch]
Message-Id: <20200714160202.3121879-3-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Markus Armbruster 2020-07-14 18:01:59 +02:00 committed by Thomas Huth
parent 12a9b8d824
commit ab2d185d6b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qom/qom-hmp-cmds.c
View File

@ -96,8 +96,10 @@ static void print_qom_composition(Monitor *mon, Object *obj, int indent);
static int qom_composition_compare(const void *a, const void *b, void *ignore) static int qom_composition_compare(const void *a, const void *b, void *ignore)
{ {
return g_strcmp0(a ? object_get_canonical_path_component(a) : NULL, g_autofree char *ac = object_get_canonical_path_component(a);
b ? object_get_canonical_path_component(b) : NULL); g_autofree char *bc = object_get_canonical_path_component(b);
return g_strcmp0(ac, bc);
} }
static int insert_qom_composition_child(Object *obj, void *opaque) static int insert_qom_composition_child(Object *obj, void *opaque)