From aafd758410015e08b1aa8964d739ba8587ce58dc Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Fri, 29 Jan 2016 17:49:55 +0000 Subject: [PATCH] util: Clean up includes Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Peter Maydell Message-id: 1454089805-5470-6-git-send-email-peter.maydell@linaro.org --- util/acl.c | 1 + util/base64.c | 1 + util/bitmap.c | 1 + util/bitops.c | 1 + util/buffer.c | 1 + util/compatfd.c | 1 + util/coroutine-gthread.c | 1 + util/coroutine-sigaltstack.c | 4 +--- util/coroutine-ucontext.c | 3 +-- util/coroutine-win32.c | 1 + util/crc32c.c | 1 + util/cutils.c | 3 +-- util/envlist.c | 1 + util/error.c | 2 +- util/event_notifier-posix.c | 1 + util/event_notifier-win32.c | 1 + util/fifo8.c | 1 + util/getauxval.c | 2 +- util/hbitmap.c | 4 +--- util/hexdump.c | 1 + util/host-utils.c | 3 +-- util/id.c | 1 + util/iov.c | 1 + util/mmap-alloc.c | 3 +-- util/module.c | 2 +- util/notify.c | 1 + util/osdep.c | 11 +---------- util/oslib-posix.c | 3 +-- util/oslib-win32.c | 3 +-- util/path.c | 7 +------ util/qemu-config.c | 2 +- util/qemu-coroutine-io.c | 1 + util/qemu-coroutine-lock.c | 1 + util/qemu-coroutine-sleep.c | 1 + util/qemu-coroutine.c | 1 + util/qemu-error.c | 2 +- util/qemu-openpty.c | 2 +- util/qemu-option.c | 4 +--- util/qemu-progress.c | 3 +-- util/qemu-sockets.c | 7 +------ util/qemu-thread-posix.c | 11 +---------- util/qemu-thread-win32.c | 3 +-- util/qemu-timer-common.c | 1 + util/rcu.c | 6 +----- util/readline.c | 1 + util/rfifolock.c | 2 +- util/throttle.c | 1 + util/timed-average.c | 2 +- util/unicode.c | 1 + util/uri.c | 3 +-- 50 files changed, 50 insertions(+), 72 deletions(-) diff --git a/util/acl.c b/util/acl.c index 571d686156..723b6a89b4 100644 --- a/util/acl.c +++ b/util/acl.c @@ -23,6 +23,7 @@ */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/acl.h" diff --git a/util/base64.c b/util/base64.c index f82caa7c8b..8aa2a5b3ac 100644 --- a/util/base64.c +++ b/util/base64.c @@ -18,6 +18,7 @@ * */ +#include "qemu/osdep.h" #include #include "qemu/base64.h" diff --git a/util/bitmap.c b/util/bitmap.c index 44f0f481be..40aadfb4f3 100644 --- a/util/bitmap.c +++ b/util/bitmap.c @@ -9,6 +9,7 @@ * Version 2. */ +#include "qemu/osdep.h" #include "qemu/bitops.h" #include "qemu/bitmap.h" #include "qemu/atomic.h" diff --git a/util/bitops.c b/util/bitops.c index 227c38b883..b0c35dd5f1 100644 --- a/util/bitops.c +++ b/util/bitops.c @@ -11,6 +11,7 @@ * 2 of the License, or (at your option) any later version. */ +#include "qemu/osdep.h" #include "qemu/bitops.h" #define BITOP_WORD(nr) ((nr) / BITS_PER_LONG) diff --git a/util/buffer.c b/util/buffer.c index 8b27c08aac..a6118bf5b2 100644 --- a/util/buffer.c +++ b/util/buffer.c @@ -18,6 +18,7 @@ * */ +#include "qemu/osdep.h" #include "qemu/buffer.h" #include "trace.h" diff --git a/util/compatfd.c b/util/compatfd.c index e8571502be..9a43042ae6 100644 --- a/util/compatfd.c +++ b/util/compatfd.c @@ -13,6 +13,7 @@ * GNU GPL, version 2 or (at your option) any later version. */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/compatfd.h" #include "qemu/thread.h" diff --git a/util/coroutine-gthread.c b/util/coroutine-gthread.c index 0bcd77867d..fb697eb0b7 100644 --- a/util/coroutine-gthread.c +++ b/util/coroutine-gthread.c @@ -18,6 +18,7 @@ * License along with this library; if not, see . */ +#include "qemu/osdep.h" #include #include "qemu-common.h" #include "qemu/coroutine_int.h" diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c index 39842a4a90..6b8aee7a2b 100644 --- a/util/coroutine-sigaltstack.c +++ b/util/coroutine-sigaltstack.c @@ -25,11 +25,9 @@ #ifdef _FORTIFY_SOURCE #undef _FORTIFY_SOURCE #endif -#include +#include "qemu/osdep.h" #include -#include #include -#include #include "qemu-common.h" #include "qemu/coroutine_int.h" diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index 26cbebb7a7..4914f60199 100644 --- a/util/coroutine-ucontext.c +++ b/util/coroutine-ucontext.c @@ -22,9 +22,8 @@ #ifdef _FORTIFY_SOURCE #undef _FORTIFY_SOURCE #endif -#include +#include "qemu/osdep.h" #include -#include #include #include "qemu-common.h" #include "qemu/coroutine_int.h" diff --git a/util/coroutine-win32.c b/util/coroutine-win32.c index 4f922c53af..02e28e825f 100644 --- a/util/coroutine-win32.c +++ b/util/coroutine-win32.c @@ -22,6 +22,7 @@ * THE SOFTWARE. */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/coroutine_int.h" diff --git a/util/crc32c.c b/util/crc32c.c index 8866327801..7e99555c16 100644 --- a/util/crc32c.c +++ b/util/crc32c.c @@ -25,6 +25,7 @@ * */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/crc32c.h" diff --git a/util/cutils.c b/util/cutils.c index cfeb848d19..59e1f70d5f 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -21,11 +21,10 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/host-utils.h" #include -#include -#include #include "qemu/sockets.h" #include "qemu/iov.h" diff --git a/util/envlist.c b/util/envlist.c index 099a544a41..e86857e70a 100644 --- a/util/envlist.c +++ b/util/envlist.c @@ -1,3 +1,4 @@ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/queue.h" #include "qemu/envlist.h" diff --git a/util/error.c b/util/error.c index 57303fd05c..471b8b3c1e 100644 --- a/util/error.c +++ b/util/error.c @@ -12,8 +12,8 @@ * the COPYING.LIB file in the top-level directory. */ +#include "qemu/osdep.h" #include "qemu-common.h" -#include "qapi/error.h" #include "qemu/error-report.h" struct Error diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c index d4a0c63e12..2e30e74bd6 100644 --- a/util/event_notifier-posix.c +++ b/util/event_notifier-posix.c @@ -10,6 +10,7 @@ * See the COPYING file in the top-level directory. */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/event_notifier.h" #include "sysemu/char.h" diff --git a/util/event_notifier-win32.c b/util/event_notifier-win32.c index 6dbb530cfa..14b4f7d2c0 100644 --- a/util/event_notifier-win32.c +++ b/util/event_notifier-win32.c @@ -10,6 +10,7 @@ * See the COPYING file in the top-level directory. */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/event_notifier.h" #include "qemu/main-loop.h" diff --git a/util/fifo8.c b/util/fifo8.c index 0ea5ad98e3..5c64101b33 100644 --- a/util/fifo8.c +++ b/util/fifo8.c @@ -12,6 +12,7 @@ * with this program; if not, see . */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/fifo8.h" diff --git a/util/getauxval.c b/util/getauxval.c index 1732ace2b1..0b3bae2dcb 100644 --- a/util/getauxval.c +++ b/util/getauxval.c @@ -22,8 +22,8 @@ * THE SOFTWARE. */ -#include "qemu-common.h" #include "qemu/osdep.h" +#include "qemu-common.h" #ifdef CONFIG_GETAUXVAL /* Don't inline this in qemu/osdep.h, because pulling in for diff --git a/util/hbitmap.c b/util/hbitmap.c index 50b888fd60..b22b87d0a6 100644 --- a/util/hbitmap.c +++ b/util/hbitmap.c @@ -9,10 +9,8 @@ * later. See the COPYING file in the top-level directory. */ -#include -#include -#include #include "qemu/osdep.h" +#include #include "qemu/hbitmap.h" #include "qemu/host-utils.h" #include "trace.h" diff --git a/util/hexdump.c b/util/hexdump.c index 969b3406c0..1d9c12967b 100644 --- a/util/hexdump.c +++ b/util/hexdump.c @@ -13,6 +13,7 @@ * GNU GPL, version 2 or (at your option) any later version. */ +#include "qemu/osdep.h" #include "qemu-common.h" void qemu_hexdump(const char *buf, FILE *fp, const char *prefix, size_t size) diff --git a/util/host-utils.c b/util/host-utils.c index 102e5bf302..b166e57586 100644 --- a/util/host-utils.c +++ b/util/host-utils.c @@ -23,8 +23,7 @@ * THE SOFTWARE. */ -#include -#include +#include "qemu/osdep.h" #include "qemu/host-utils.h" /* Long integer helpers */ diff --git a/util/id.c b/util/id.c index 7883fbec79..bbbadcc784 100644 --- a/util/id.c +++ b/util/id.c @@ -10,6 +10,7 @@ * or later. See the COPYING.LIB file in the top-level directory. */ +#include "qemu/osdep.h" #include "qemu-common.h" bool id_wellformed(const char *id) diff --git a/util/iov.c b/util/iov.c index a0d5934e8e..e802ee15bc 100644 --- a/util/iov.c +++ b/util/iov.c @@ -16,6 +16,7 @@ * GNU GPL, version 2 or (at your option) any later version. */ +#include "qemu/osdep.h" #include "qemu/iov.h" #include "qemu/sockets.h" diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c index 5cd7f71ac3..0b4cc7f7f1 100644 --- a/util/mmap-alloc.c +++ b/util/mmap-alloc.c @@ -9,10 +9,9 @@ * This work is licensed under the terms of the GNU GPL, version 2 or * later. See the COPYING file in the top-level directory. */ +#include "qemu/osdep.h" #include -#include #include -#include #define HUGETLBFS_MAGIC 0x958458f6 diff --git a/util/module.c b/util/module.c index 4bd4a94d87..ce058aef6f 100644 --- a/util/module.c +++ b/util/module.c @@ -13,7 +13,7 @@ * GNU GPL, version 2 or (at your option) any later version. */ -#include +#include "qemu/osdep.h" #include "qemu-common.h" #ifdef CONFIG_MODULES #include diff --git a/util/notify.c b/util/notify.c index f215dfc214..06de63a839 100644 --- a/util/notify.c +++ b/util/notify.c @@ -13,6 +13,7 @@ * GNU GPL, version 2 or (at your option) any later version. */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/notify.h" diff --git a/util/osdep.c b/util/osdep.c index 534b51147c..8356bdd3d8 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -21,24 +21,15 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ -#include -#include -#include -#include -#include -#include -#include -#include +#include "qemu/osdep.h" /* Needed early for CONFIG_BSD etc. */ -#include "config-host.h" #if defined(CONFIG_MADVISE) || defined(CONFIG_POSIX_MADVISE) #include #endif #ifdef CONFIG_SOLARIS -#include #include /* See MySQL bug #7156 (http://bugs.mysql.com/bug.php?id=7156) for discussion about Solaris header problems */ diff --git a/util/oslib-posix.c b/util/oslib-posix.c index d25f6715c7..d844387b79 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -47,13 +47,12 @@ extern int daemon(int, int); # define QEMU_VMALLOC_ALIGN getpagesize() #endif +#include "qemu/osdep.h" #include -#include #include #include -#include "config-host.h" #include "sysemu/sysemu.h" #include "trace.h" #include "qemu/sockets.h" diff --git a/util/oslib-win32.c b/util/oslib-win32.c index 6a47019dfb..438cfa4f6a 100644 --- a/util/oslib-win32.c +++ b/util/oslib-win32.c @@ -29,10 +29,9 @@ * this file are based on code from GNOME glib-2 and use a different license, * see the license comment there. */ +#include "qemu/osdep.h" #include #include -#include -#include "config-host.h" #include "sysemu/sysemu.h" #include "qemu/main-loop.h" #include "trace.h" diff --git a/util/path.c b/util/path.c index 4e4877e821..d09e8c5e14 100644 --- a/util/path.c +++ b/util/path.c @@ -3,14 +3,9 @@ The assumption is that this area does not change. */ -#include +#include "qemu/osdep.h" #include #include -#include -#include -#include -#include -#include #include "qemu-common.h" struct pathelem diff --git a/util/qemu-config.c b/util/qemu-config.c index 687fd34cc6..fb973074d3 100644 --- a/util/qemu-config.c +++ b/util/qemu-config.c @@ -1,8 +1,8 @@ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/error-report.h" #include "qemu/option.h" #include "qemu/config-file.h" -#include "qapi/error.h" #include "qmp-commands.h" static QemuOptsList *vm_config_groups[48]; diff --git a/util/qemu-coroutine-io.c b/util/qemu-coroutine-io.c index e1eae7331e..0d5041c1c3 100644 --- a/util/qemu-coroutine-io.c +++ b/util/qemu-coroutine-io.c @@ -22,6 +22,7 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/sockets.h" #include "qemu/coroutine.h" diff --git a/util/qemu-coroutine-lock.c b/util/qemu-coroutine-lock.c index 130ee19d17..da37ca7f95 100644 --- a/util/qemu-coroutine-lock.c +++ b/util/qemu-coroutine-lock.c @@ -22,6 +22,7 @@ * THE SOFTWARE. */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/coroutine.h" #include "qemu/coroutine_int.h" diff --git a/util/qemu-coroutine-sleep.c b/util/qemu-coroutine-sleep.c index b35db56356..6966831d37 100644 --- a/util/qemu-coroutine-sleep.c +++ b/util/qemu-coroutine-sleep.c @@ -11,6 +11,7 @@ * */ +#include "qemu/osdep.h" #include "qemu/coroutine.h" #include "qemu/timer.h" #include "block/aio.h" diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c index 8953560223..5816702cc5 100644 --- a/util/qemu-coroutine.c +++ b/util/qemu-coroutine.c @@ -12,6 +12,7 @@ * */ +#include "qemu/osdep.h" #include "trace.h" #include "qemu-common.h" #include "qemu/thread.h" diff --git a/util/qemu-error.c b/util/qemu-error.c index ecf5708478..1ef35664af 100644 --- a/util/qemu-error.c +++ b/util/qemu-error.c @@ -10,7 +10,7 @@ * See the COPYING file in the top-level directory. */ -#include +#include "qemu/osdep.h" #include "monitor/monitor.h" #include "qemu/error-report.h" diff --git a/util/qemu-openpty.c b/util/qemu-openpty.c index 4c5321116b..2e8b43bdf5 100644 --- a/util/qemu-openpty.c +++ b/util/qemu-openpty.c @@ -32,7 +32,7 @@ * linked with -lutil. */ -#include "config-host.h" +#include "qemu/osdep.h" #include "qemu-common.h" #if defined(__GLIBC__) diff --git a/util/qemu-option.c b/util/qemu-option.c index a2d593ad2b..e7aa43f857 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -23,13 +23,11 @@ * THE SOFTWARE. */ -#include -#include +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/error-report.h" #include "qapi/qmp/types.h" -#include "qapi/error.h" #include "qapi/qmp/qerror.h" #include "qemu/option_int.h" diff --git a/util/qemu-progress.c b/util/qemu-progress.c index 532333e757..f745233763 100644 --- a/util/qemu-progress.c +++ b/util/qemu-progress.c @@ -22,9 +22,8 @@ * THE SOFTWARE. */ -#include "qemu-common.h" #include "qemu/osdep.h" -#include +#include "qemu-common.h" struct progress_state { float current; diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index f455a1748f..51354dfb6d 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -15,12 +15,7 @@ * Contributions after 2012-01-13 are licensed under the terms of the * GNU GPL, version 2 or (at your option) any later version. */ -#include -#include -#include -#include -#include -#include +#include "qemu/osdep.h" #include "monitor/monitor.h" #include "qemu/sockets.h" diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c index dbd8094fce..74a3023f3e 100644 --- a/util/qemu-thread-posix.c +++ b/util/qemu-thread-posix.c @@ -10,16 +10,7 @@ * See the COPYING file in the top-level directory. * */ -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include "qemu/osdep.h" #ifdef __linux__ #include #include diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c index 6cdd553e9a..98a5ddff82 100644 --- a/util/qemu-thread-win32.c +++ b/util/qemu-thread-win32.c @@ -10,12 +10,11 @@ * See the COPYING file in the top-level directory. * */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/thread.h" #include "qemu/notify.h" #include -#include -#include static bool name_threads; diff --git a/util/qemu-timer-common.c b/util/qemu-timer-common.c index 95e0847c76..06d084d364 100644 --- a/util/qemu-timer-common.c +++ b/util/qemu-timer-common.c @@ -21,6 +21,7 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ +#include "qemu/osdep.h" #include "qemu/timer.h" /***********************************************************/ diff --git a/util/rcu.c b/util/rcu.c index 8ba304dc44..bceb3e4720 100644 --- a/util/rcu.c +++ b/util/rcu.c @@ -26,12 +26,8 @@ * IBM's contributions to this file may be relicensed under LGPLv2 or later. */ +#include "qemu/osdep.h" #include "qemu-common.h" -#include -#include -#include -#include -#include #include "qemu/rcu.h" #include "qemu/atomic.h" #include "qemu/thread.h" diff --git a/util/readline.c b/util/readline.c index cc1302ac0a..e94c97521b 100644 --- a/util/readline.c +++ b/util/readline.c @@ -22,6 +22,7 @@ * THE SOFTWARE. */ +#include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/readline.h" diff --git a/util/rfifolock.c b/util/rfifolock.c index afbf7488df..c22f5feeee 100644 --- a/util/rfifolock.c +++ b/util/rfifolock.c @@ -11,7 +11,7 @@ * */ -#include +#include "qemu/osdep.h" #include "qemu/rfifolock.h" void rfifolock_init(RFifoLock *r, void (*cb)(void *), void *opaque) diff --git a/util/throttle.c b/util/throttle.c index af4bc95ba3..2f9b23d925 100644 --- a/util/throttle.c +++ b/util/throttle.c @@ -22,6 +22,7 @@ * along with this program; if not, see . */ +#include "qemu/osdep.h" #include "qemu/throttle.h" #include "qemu/timer.h" #include "block/aio.h" diff --git a/util/timed-average.c b/util/timed-average.c index a2dfb4834d..2eef9cbb19 100644 --- a/util/timed-average.c +++ b/util/timed-average.c @@ -22,7 +22,7 @@ * along with this program. If not, see . */ -#include +#include "qemu/osdep.h" #include "qemu/timed-average.h" diff --git a/util/unicode.c b/util/unicode.c index d1c8658850..524dca8c7c 100644 --- a/util/unicode.c +++ b/util/unicode.c @@ -10,6 +10,7 @@ * later. See the COPYING file in the top-level directory. */ +#include "qemu/osdep.h" #include "qemu-common.h" /** diff --git a/util/uri.c b/util/uri.c index 550b984587..d109d6c01d 100644 --- a/util/uri.c +++ b/util/uri.c @@ -51,9 +51,8 @@ * */ +#include "qemu/osdep.h" #include -#include -#include #include "qemu/uri.h"