alsaaudio: port to -audiodev config

Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
Message-id: 663d2c918a11ef44d4042e56c796d6dbf40be70c.1552083282.git.DirtY.iCE.hu@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Kővágó, Zoltán 2019-03-08 23:34:16 +01:00 committed by Gerd Hoffmann
parent 71830221fb
commit a93f328177
2 changed files with 181 additions and 232 deletions

View File

@ -33,28 +33,9 @@
#define AUDIO_CAP "alsa" #define AUDIO_CAP "alsa"
#include "audio_int.h" #include "audio_int.h"
typedef struct ALSAConf {
int size_in_usec_in;
int size_in_usec_out;
const char *pcm_name_in;
const char *pcm_name_out;
unsigned int buffer_size_in;
unsigned int period_size_in;
unsigned int buffer_size_out;
unsigned int period_size_out;
unsigned int threshold;
int buffer_size_in_overridden;
int period_size_in_overridden;
int buffer_size_out_overridden;
int period_size_out_overridden;
} ALSAConf;
struct pollhlp { struct pollhlp {
snd_pcm_t *handle; snd_pcm_t *handle;
struct pollfd *pfds; struct pollfd *pfds;
ALSAConf *conf;
int count; int count;
int mask; int mask;
}; };
@ -66,6 +47,7 @@ typedef struct ALSAVoiceOut {
void *pcm_buf; void *pcm_buf;
snd_pcm_t *handle; snd_pcm_t *handle;
struct pollhlp pollhlp; struct pollhlp pollhlp;
Audiodev *dev;
} ALSAVoiceOut; } ALSAVoiceOut;
typedef struct ALSAVoiceIn { typedef struct ALSAVoiceIn {
@ -73,16 +55,13 @@ typedef struct ALSAVoiceIn {
snd_pcm_t *handle; snd_pcm_t *handle;
void *pcm_buf; void *pcm_buf;
struct pollhlp pollhlp; struct pollhlp pollhlp;
Audiodev *dev;
} ALSAVoiceIn; } ALSAVoiceIn;
struct alsa_params_req { struct alsa_params_req {
int freq; int freq;
snd_pcm_format_t fmt; snd_pcm_format_t fmt;
int nchannels; int nchannels;
int size_in_usec;
int override_mask;
unsigned int buffer_size;
unsigned int period_size;
}; };
struct alsa_params_obt { struct alsa_params_obt {
@ -408,17 +387,18 @@ static int alsa_to_audfmt (snd_pcm_format_t alsafmt, AudioFormat *fmt,
static void alsa_dump_info (struct alsa_params_req *req, static void alsa_dump_info (struct alsa_params_req *req,
struct alsa_params_obt *obt, struct alsa_params_obt *obt,
snd_pcm_format_t obtfmt) snd_pcm_format_t obtfmt,
AudiodevAlsaPerDirectionOptions *apdo)
{ {
dolog ("parameter | requested value | obtained value\n"); dolog("parameter | requested value | obtained value\n");
dolog ("format | %10d | %10d\n", req->fmt, obtfmt); dolog("format | %10d | %10d\n", req->fmt, obtfmt);
dolog ("channels | %10d | %10d\n", dolog("channels | %10d | %10d\n",
req->nchannels, obt->nchannels); req->nchannels, obt->nchannels);
dolog ("frequency | %10d | %10d\n", req->freq, obt->freq); dolog("frequency | %10d | %10d\n", req->freq, obt->freq);
dolog ("============================================\n"); dolog("============================================\n");
dolog ("requested: buffer size %d period size %d\n", dolog("requested: buffer len %" PRId32 " period len %" PRId32 "\n",
req->buffer_size, req->period_size); apdo->buffer_length, apdo->period_length);
dolog ("obtained: samples %ld\n", obt->samples); dolog("obtained: samples %ld\n", obt->samples);
} }
static void alsa_set_threshold (snd_pcm_t *handle, snd_pcm_uframes_t threshold) static void alsa_set_threshold (snd_pcm_t *handle, snd_pcm_uframes_t threshold)
@ -451,23 +431,23 @@ static void alsa_set_threshold (snd_pcm_t *handle, snd_pcm_uframes_t threshold)
} }
} }
static int alsa_open (int in, struct alsa_params_req *req, static int alsa_open(bool in, struct alsa_params_req *req,
struct alsa_params_obt *obt, snd_pcm_t **handlep, struct alsa_params_obt *obt, snd_pcm_t **handlep,
ALSAConf *conf) Audiodev *dev)
{ {
AudiodevAlsaOptions *aopts = &dev->u.alsa;
AudiodevAlsaPerDirectionOptions *apdo = in ? aopts->in : aopts->out;
snd_pcm_t *handle; snd_pcm_t *handle;
snd_pcm_hw_params_t *hw_params; snd_pcm_hw_params_t *hw_params;
int err; int err;
int size_in_usec;
unsigned int freq, nchannels; unsigned int freq, nchannels;
const char *pcm_name = in ? conf->pcm_name_in : conf->pcm_name_out; const char *pcm_name = apdo->has_dev ? apdo->dev : "default";
snd_pcm_uframes_t obt_buffer_size; snd_pcm_uframes_t obt_buffer_size;
const char *typ = in ? "ADC" : "DAC"; const char *typ = in ? "ADC" : "DAC";
snd_pcm_format_t obtfmt; snd_pcm_format_t obtfmt;
freq = req->freq; freq = req->freq;
nchannels = req->nchannels; nchannels = req->nchannels;
size_in_usec = req->size_in_usec;
snd_pcm_hw_params_alloca (&hw_params); snd_pcm_hw_params_alloca (&hw_params);
@ -527,79 +507,42 @@ static int alsa_open (int in, struct alsa_params_req *req,
goto err; goto err;
} }
if (req->buffer_size) { if (apdo->buffer_length) {
unsigned long obt;
if (size_in_usec) {
int dir = 0; int dir = 0;
unsigned int btime = req->buffer_size; unsigned int btime = apdo->buffer_length;
err = snd_pcm_hw_params_set_buffer_time_near ( err = snd_pcm_hw_params_set_buffer_time_near(
handle, handle, hw_params, &btime, &dir);
hw_params,
&btime,
&dir
);
obt = btime;
}
else {
snd_pcm_uframes_t bsize = req->buffer_size;
err = snd_pcm_hw_params_set_buffer_size_near (
handle,
hw_params,
&bsize
);
obt = bsize;
}
if (err < 0) { if (err < 0) {
alsa_logerr2 (err, typ, "Failed to set buffer %s to %d\n", alsa_logerr2(err, typ, "Failed to set buffer time to %" PRId32 "\n",
size_in_usec ? "time" : "size", req->buffer_size); apdo->buffer_length);
goto err; goto err;
} }
if ((req->override_mask & 2) && (obt - req->buffer_size)) if (apdo->has_buffer_length && btime != apdo->buffer_length) {
dolog ("Requested buffer %s %u was rejected, using %lu\n", dolog("Requested buffer time %" PRId32
size_in_usec ? "time" : "size", req->buffer_size, obt); " was rejected, using %u\n", apdo->buffer_length, btime);
}
} }
if (req->period_size) { if (apdo->period_length) {
unsigned long obt;
if (size_in_usec) {
int dir = 0; int dir = 0;
unsigned int ptime = req->period_size; unsigned int ptime = apdo->period_length;
err = snd_pcm_hw_params_set_period_time_near ( err = snd_pcm_hw_params_set_period_time_near(handle, hw_params, &ptime,
handle, &dir);
hw_params,
&ptime,
&dir
);
obt = ptime;
}
else {
int dir = 0;
snd_pcm_uframes_t psize = req->period_size;
err = snd_pcm_hw_params_set_period_size_near (
handle,
hw_params,
&psize,
&dir
);
obt = psize;
}
if (err < 0) { if (err < 0) {
alsa_logerr2 (err, typ, "Failed to set period %s to %d\n", alsa_logerr2(err, typ, "Failed to set period time to %" PRId32 "\n",
size_in_usec ? "time" : "size", req->period_size); apdo->period_length);
goto err; goto err;
} }
if (((req->override_mask & 1) && (obt - req->period_size))) if (apdo->has_period_length && ptime != apdo->period_length) {
dolog ("Requested period %s %u was rejected, using %lu\n", dolog("Requested period time %" PRId32 " was rejected, using %d\n",
size_in_usec ? "time" : "size", req->period_size, obt); apdo->period_length, ptime);
}
} }
err = snd_pcm_hw_params (handle, hw_params); err = snd_pcm_hw_params (handle, hw_params);
@ -631,33 +574,12 @@ static int alsa_open (int in, struct alsa_params_req *req,
goto err; goto err;
} }
if (!in && conf->threshold) { if (!in && aopts->has_threshold && aopts->threshold) {
snd_pcm_uframes_t threshold; struct audsettings as = { .freq = freq };
int bytes_per_sec; alsa_set_threshold(
handle,
bytes_per_sec = freq << (nchannels == 2); audio_buffer_frames(qapi_AudiodevAlsaPerDirectionOptions_base(apdo),
&as, aopts->threshold));
switch (obt->fmt) {
case AUDIO_FORMAT_S8:
case AUDIO_FORMAT_U8:
break;
case AUDIO_FORMAT_S16:
case AUDIO_FORMAT_U16:
bytes_per_sec <<= 1;
break;
case AUDIO_FORMAT_S32:
case AUDIO_FORMAT_U32:
bytes_per_sec <<= 2;
break;
default:
abort();
}
threshold = (conf->threshold * bytes_per_sec) / 1000;
alsa_set_threshold (handle, threshold);
} }
obt->nchannels = nchannels; obt->nchannels = nchannels;
@ -670,11 +592,11 @@ static int alsa_open (int in, struct alsa_params_req *req,
obt->nchannels != req->nchannels || obt->nchannels != req->nchannels ||
obt->freq != req->freq) { obt->freq != req->freq) {
dolog ("Audio parameters for %s\n", typ); dolog ("Audio parameters for %s\n", typ);
alsa_dump_info (req, obt, obtfmt); alsa_dump_info(req, obt, obtfmt, apdo);
} }
#ifdef DEBUG #ifdef DEBUG
alsa_dump_info (req, obt, obtfmt); alsa_dump_info(req, obt, obtfmt, pdo);
#endif #endif
return 0; return 0;
@ -800,19 +722,13 @@ static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as,
struct alsa_params_obt obt; struct alsa_params_obt obt;
snd_pcm_t *handle; snd_pcm_t *handle;
struct audsettings obt_as; struct audsettings obt_as;
ALSAConf *conf = drv_opaque; Audiodev *dev = drv_opaque;
req.fmt = aud_to_alsafmt (as->fmt, as->endianness); req.fmt = aud_to_alsafmt (as->fmt, as->endianness);
req.freq = as->freq; req.freq = as->freq;
req.nchannels = as->nchannels; req.nchannels = as->nchannels;
req.period_size = conf->period_size_out;
req.buffer_size = conf->buffer_size_out;
req.size_in_usec = conf->size_in_usec_out;
req.override_mask =
(conf->period_size_out_overridden ? 1 : 0) |
(conf->buffer_size_out_overridden ? 2 : 0);
if (alsa_open (0, &req, &obt, &handle, conf)) { if (alsa_open(0, &req, &obt, &handle, dev)) {
return -1; return -1;
} }
@ -833,7 +749,7 @@ static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as,
} }
alsa->handle = handle; alsa->handle = handle;
alsa->pollhlp.conf = conf; alsa->dev = dev;
return 0; return 0;
} }
@ -873,16 +789,12 @@ static int alsa_voice_ctl (snd_pcm_t *handle, const char *typ, int ctl)
static int alsa_ctl_out (HWVoiceOut *hw, int cmd, ...) static int alsa_ctl_out (HWVoiceOut *hw, int cmd, ...)
{ {
ALSAVoiceOut *alsa = (ALSAVoiceOut *) hw; ALSAVoiceOut *alsa = (ALSAVoiceOut *) hw;
AudiodevAlsaPerDirectionOptions *apdo = alsa->dev->u.alsa.out;
switch (cmd) { switch (cmd) {
case VOICE_ENABLE: case VOICE_ENABLE:
{ {
va_list ap; bool poll_mode = apdo->try_poll;
int poll_mode;
va_start (ap, cmd);
poll_mode = va_arg (ap, int);
va_end (ap);
ldebug ("enabling voice\n"); ldebug ("enabling voice\n");
if (poll_mode && alsa_poll_out (hw)) { if (poll_mode && alsa_poll_out (hw)) {
@ -911,19 +823,13 @@ static int alsa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque)
struct alsa_params_obt obt; struct alsa_params_obt obt;
snd_pcm_t *handle; snd_pcm_t *handle;
struct audsettings obt_as; struct audsettings obt_as;
ALSAConf *conf = drv_opaque; Audiodev *dev = drv_opaque;
req.fmt = aud_to_alsafmt (as->fmt, as->endianness); req.fmt = aud_to_alsafmt (as->fmt, as->endianness);
req.freq = as->freq; req.freq = as->freq;
req.nchannels = as->nchannels; req.nchannels = as->nchannels;
req.period_size = conf->period_size_in;
req.buffer_size = conf->buffer_size_in;
req.size_in_usec = conf->size_in_usec_in;
req.override_mask =
(conf->period_size_in_overridden ? 1 : 0) |
(conf->buffer_size_in_overridden ? 2 : 0);
if (alsa_open (1, &req, &obt, &handle, conf)) { if (alsa_open(1, &req, &obt, &handle, dev)) {
return -1; return -1;
} }
@ -944,7 +850,7 @@ static int alsa_init_in(HWVoiceIn *hw, struct audsettings *as, void *drv_opaque)
} }
alsa->handle = handle; alsa->handle = handle;
alsa->pollhlp.conf = conf; alsa->dev = dev;
return 0; return 0;
} }
@ -1086,16 +992,12 @@ static int alsa_read (SWVoiceIn *sw, void *buf, int size)
static int alsa_ctl_in (HWVoiceIn *hw, int cmd, ...) static int alsa_ctl_in (HWVoiceIn *hw, int cmd, ...)
{ {
ALSAVoiceIn *alsa = (ALSAVoiceIn *) hw; ALSAVoiceIn *alsa = (ALSAVoiceIn *) hw;
AudiodevAlsaPerDirectionOptions *apdo = alsa->dev->u.alsa.in;
switch (cmd) { switch (cmd) {
case VOICE_ENABLE: case VOICE_ENABLE:
{ {
va_list ap; bool poll_mode = apdo->try_poll;
int poll_mode;
va_start (ap, cmd);
poll_mode = va_arg (ap, int);
va_end (ap);
ldebug ("enabling voice\n"); ldebug ("enabling voice\n");
if (poll_mode && alsa_poll_in (hw)) { if (poll_mode && alsa_poll_in (hw)) {
@ -1118,88 +1020,54 @@ static int alsa_ctl_in (HWVoiceIn *hw, int cmd, ...)
return -1; return -1;
} }
static ALSAConf glob_conf = { static void alsa_init_per_direction(AudiodevAlsaPerDirectionOptions *apdo)
.buffer_size_out = 4096, {
.period_size_out = 1024, if (!apdo->has_try_poll) {
.pcm_name_out = "default", apdo->try_poll = true;
.pcm_name_in = "default", apdo->has_try_poll = true;
}; }
}
static void *alsa_audio_init(Audiodev *dev) static void *alsa_audio_init(Audiodev *dev)
{ {
ALSAConf *conf = g_malloc(sizeof(ALSAConf)); AudiodevAlsaOptions *aopts;
*conf = glob_conf; assert(dev->driver == AUDIODEV_DRIVER_ALSA);
return conf;
aopts = &dev->u.alsa;
alsa_init_per_direction(aopts->in);
alsa_init_per_direction(aopts->out);
/*
* need to define them, as otherwise alsa produces no sound
* doesn't set has_* so alsa_open can identify it wasn't set by the user
*/
if (!dev->u.alsa.out->has_period_length) {
/* 1024 frames assuming 44100Hz */
dev->u.alsa.out->period_length = 1024 * 1000000 / 44100;
}
if (!dev->u.alsa.out->has_buffer_length) {
/* 4096 frames assuming 44100Hz */
dev->u.alsa.out->buffer_length = 4096ll * 1000000 / 44100;
}
/*
* OptsVisitor sets unspecified optional fields to zero, but do not depend
* on it...
*/
if (!dev->u.alsa.in->has_period_length) {
dev->u.alsa.in->period_length = 0;
}
if (!dev->u.alsa.in->has_buffer_length) {
dev->u.alsa.in->buffer_length = 0;
}
return dev;
} }
static void alsa_audio_fini (void *opaque) static void alsa_audio_fini (void *opaque)
{ {
g_free(opaque);
} }
static struct audio_option alsa_options[] = {
{
.name = "DAC_SIZE_IN_USEC",
.tag = AUD_OPT_BOOL,
.valp = &glob_conf.size_in_usec_out,
.descr = "DAC period/buffer size in microseconds (otherwise in frames)"
},
{
.name = "DAC_PERIOD_SIZE",
.tag = AUD_OPT_INT,
.valp = &glob_conf.period_size_out,
.descr = "DAC period size (0 to go with system default)",
.overriddenp = &glob_conf.period_size_out_overridden
},
{
.name = "DAC_BUFFER_SIZE",
.tag = AUD_OPT_INT,
.valp = &glob_conf.buffer_size_out,
.descr = "DAC buffer size (0 to go with system default)",
.overriddenp = &glob_conf.buffer_size_out_overridden
},
{
.name = "ADC_SIZE_IN_USEC",
.tag = AUD_OPT_BOOL,
.valp = &glob_conf.size_in_usec_in,
.descr =
"ADC period/buffer size in microseconds (otherwise in frames)"
},
{
.name = "ADC_PERIOD_SIZE",
.tag = AUD_OPT_INT,
.valp = &glob_conf.period_size_in,
.descr = "ADC period size (0 to go with system default)",
.overriddenp = &glob_conf.period_size_in_overridden
},
{
.name = "ADC_BUFFER_SIZE",
.tag = AUD_OPT_INT,
.valp = &glob_conf.buffer_size_in,
.descr = "ADC buffer size (0 to go with system default)",
.overriddenp = &glob_conf.buffer_size_in_overridden
},
{
.name = "THRESHOLD",
.tag = AUD_OPT_INT,
.valp = &glob_conf.threshold,
.descr = "(undocumented)"
},
{
.name = "DAC_DEV",
.tag = AUD_OPT_STR,
.valp = &glob_conf.pcm_name_out,
.descr = "DAC device name (for instance dmix)"
},
{
.name = "ADC_DEV",
.tag = AUD_OPT_STR,
.valp = &glob_conf.pcm_name_in,
.descr = "ADC device name"
},
{ /* End of list */ }
};
static struct audio_pcm_ops alsa_pcm_ops = { static struct audio_pcm_ops alsa_pcm_ops = {
.init_out = alsa_init_out, .init_out = alsa_init_out,
.fini_out = alsa_fini_out, .fini_out = alsa_fini_out,
@ -1217,7 +1085,6 @@ static struct audio_pcm_ops alsa_pcm_ops = {
static struct audio_driver alsa_audio_driver = { static struct audio_driver alsa_audio_driver = {
.name = "alsa", .name = "alsa",
.descr = "ALSA http://www.alsa-project.org", .descr = "ALSA http://www.alsa-project.org",
.options = alsa_options,
.init = alsa_audio_init, .init = alsa_audio_init,
.fini = alsa_audio_fini, .fini = alsa_audio_fini,
.pcm_ops = &alsa_pcm_ops, .pcm_ops = &alsa_pcm_ops,

View File

@ -62,6 +62,18 @@ static void get_int(const char *env, uint32_t *dst, bool *has_dst)
} }
} }
static void get_str(const char *env, char **dst, bool *has_dst)
{
const char *val = getenv(env);
if (val) {
if (*has_dst) {
g_free(*dst);
}
*dst = g_strdup(val);
*has_dst = true;
}
}
static void get_fmt(const char *env, AudioFormat *dst, bool *has_dst) static void get_fmt(const char *env, AudioFormat *dst, bool *has_dst)
{ {
const char *val = getenv(env); const char *val = getenv(env);
@ -80,8 +92,69 @@ static void get_fmt(const char *env, AudioFormat *dst, bool *has_dst)
} }
} }
static void get_millis_to_usecs(const char *env, uint32_t *dst, bool *has_dst)
{
const char *val = getenv(env);
if (val) {
*dst = toui32(val) * 1000;
*has_dst = true;
}
}
static uint32_t frames_to_usecs(uint32_t frames,
AudiodevPerDirectionOptions *pdo)
{
uint32_t freq = pdo->has_frequency ? pdo->frequency : 44100;
return (frames * 1000000 + freq / 2) / freq;
}
/* backend specific functions */ /* backend specific functions */
/* todo */ /* ALSA */
static void handle_alsa_per_direction(
AudiodevAlsaPerDirectionOptions *apdo, const char *prefix)
{
char buf[64];
size_t len = strlen(prefix);
bool size_in_usecs = false;
bool dummy;
memcpy(buf, prefix, len);
strcpy(buf + len, "TRY_POLL");
get_bool(buf, &apdo->try_poll, &apdo->has_try_poll);
strcpy(buf + len, "DEV");
get_str(buf, &apdo->dev, &apdo->has_dev);
strcpy(buf + len, "SIZE_IN_USEC");
get_bool(buf, &size_in_usecs, &dummy);
strcpy(buf + len, "PERIOD_SIZE");
get_int(buf, &apdo->period_length, &apdo->has_period_length);
if (apdo->has_period_length && !size_in_usecs) {
apdo->period_length = frames_to_usecs(
apdo->period_length,
qapi_AudiodevAlsaPerDirectionOptions_base(apdo));
}
strcpy(buf + len, "BUFFER_SIZE");
get_int(buf, &apdo->buffer_length, &apdo->has_buffer_length);
if (apdo->has_buffer_length && !size_in_usecs) {
apdo->buffer_length = frames_to_usecs(
apdo->buffer_length,
qapi_AudiodevAlsaPerDirectionOptions_base(apdo));
}
}
static void handle_alsa(Audiodev *dev)
{
AudiodevAlsaOptions *aopt = &dev->u.alsa;
handle_alsa_per_direction(aopt->in, "QEMU_ALSA_ADC_");
handle_alsa_per_direction(aopt->out, "QEMU_ALSA_DAC_");
get_millis_to_usecs("QEMU_ALSA_THRESHOLD",
&aopt->threshold, &aopt->has_threshold);
}
/* general */ /* general */
static void handle_per_direction( static void handle_per_direction(
@ -123,6 +196,15 @@ static AudiodevListEntry *legacy_opt(const char *drvname)
get_int("QEMU_AUDIO_TIMER_PERIOD", get_int("QEMU_AUDIO_TIMER_PERIOD",
&e->dev->timer_period, &e->dev->has_timer_period); &e->dev->timer_period, &e->dev->has_timer_period);
switch (e->dev->driver) {
case AUDIODEV_DRIVER_ALSA:
handle_alsa(e->dev);
break;
default:
break;
}
return e; return e;
} }