mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

virtio: Tell the user what went wrong when event_notifier_init failed

Browse Source 
event_notifier_init() can fail in real life, for example when there
are not enough open file handles available (EMFILE) when using a lot
of devices. So instead of leaving the average user with a cryptic
error number only, print out a proper error message with strerror()
instead, so that the user has a better way to figure out what is
going on and that using "ulimit -n" might help here for example.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Thomas Huth 2016-06-28 00:12:03 +02:00 committed by Michael S. Tsirkin
parent c2a57aae9a
commit a8bba0ada4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/virtio/virtio-bus.c
View File

@ -164,7 +164,8 @@ static int set_host_notifier_internal(DeviceState *proxy, VirtioBusState *bus,
if (assign) { if (assign) {
r = event_notifier_init(notifier, 1); r = event_notifier_init(notifier, 1);
if (r < 0) { if (r < 0) {
error_report("%s: unable to init event notifier: %d", __func__, r); error_report("%s: unable to init event notifier: %s (%d)",
__func__, strerror(-r), r);
return r; return r;
} }
virtio_queue_set_host_notifier_fd_handler(vq, true, set_handler); virtio_queue_set_host_notifier_fd_handler(vq, true, set_handler);