mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qemu-io: Fix writethrough check in reopen

Browse Source 
"qemu-io reopen" doesn't allow changing the writethrough setting of
the cache, but the check is wrong, causing an error even on a simple
reopen with the default parameters:

   $ qemu-img create -f qcow2 hd.qcow2 1M
   $ qemu-system-x86_64 -monitor stdio -drive if=virtio,file=hd.qcow2
   (qemu) qemu-io virtio0 reopen
   Cannot change cache.writeback: Device attached

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Alberto Garcia 2018-09-06 12:37:01 +03:00 committed by Kevin Wolf
parent b857431d2a
commit a8003ec40d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qemu-io-cmds.c
View File

@ -2025,7 +2025,7 @@ static int reopen_f(BlockBackend *blk, int argc, char **argv)
return -EINVAL; return -EINVAL;
} }
if (writethrough != blk_enable_write_cache(blk) && if (!writethrough != blk_enable_write_cache(blk) &&
blk_get_attached_dev(blk)) blk_get_attached_dev(blk))
{ {
error_report("Cannot change cache.writeback: Device attached"); error_report("Cannot change cache.writeback: Device attached");