mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Hexagon (disas/hexagon.c) fix memory leak for early exit cases

Browse Source 
Don't allocate the string until error conditions have been checked

Fixes: a00cfed0e ("Hexagon (disas) disassembler")
Eliminate Coverity CID 1460121 (Resource leak)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daud? <f4bug@amsat.org>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
This commit is contained in:
Taylor Simpson 2021-08-12 06:53:09 -05:00
parent 703e8cd618
commit a7686d5d85
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
disas/hexagon.c
View File

@ -33,7 +33,7 @@ int print_insn_hexagon(bfd_vma memaddr, struct disassemble_info *info)
{ {
uint32_t words[PACKET_WORDS_MAX]; uint32_t words[PACKET_WORDS_MAX];
bool found_end = false; bool found_end = false;
GString *buf = g_string_sized_new(PACKET_BUFFER_LEN); GString *buf;
int i, len; int i, len;
for (i = 0; i < PACKET_WORDS_MAX && !found_end; i++) { for (i = 0; i < PACKET_WORDS_MAX && !found_end; i++) {
@ -57,6 +57,7 @@ int print_insn_hexagon(bfd_vma memaddr, struct disassemble_info *info)
return PACKET_WORDS_MAX * sizeof(uint32_t); return PACKET_WORDS_MAX * sizeof(uint32_t);
} }
buf = g_string_sized_new(PACKET_BUFFER_LEN);
len = disassemble_hexagon(words, i, memaddr, buf); len = disassemble_hexagon(words, i, memaddr, buf);
(*info->fprintf_func)(info->stream, "%s", buf->str); (*info->fprintf_func)(info->stream, "%s", buf->str);
g_string_free(buf, true); g_string_free(buf, true);