mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vfio: simplify the conditional statements in vfio_msi_enable

Browse Source 
It's unnecessary to test against the specific return value of
VFIO_DEVICE_SET_IRQS, since any positive return is an error
indicating the number of vectors we should retry with.

Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
Link: https://lore.kernel.org/r/20220326060226.1892-2-longpeng2@huawei.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
Longpeng(Mike) 2022-03-26 14:02:22 +08:00 committed by Alex Williamson
parent 31abf61c49
commit a6f5770fb2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/vfio/pci.c
View File

@ -653,7 +653,7 @@ retry:
if (ret) { if (ret) {
if (ret < 0) { if (ret < 0) {
error_report("vfio: Error: Failed to setup MSI fds: %m"); error_report("vfio: Error: Failed to setup MSI fds: %m");
} else if (ret != vdev->nr_vectors) { } else {
error_report("vfio: Error: Failed to enable %d " error_report("vfio: Error: Failed to enable %d "
"MSI vectors, retry with %d", vdev->nr_vectors, ret); "MSI vectors, retry with %d", vdev->nr_vectors, ret);
} }
@ -671,7 +671,7 @@ retry:
g_free(vdev->msi_vectors); g_free(vdev->msi_vectors);
vdev->msi_vectors = NULL; vdev->msi_vectors = NULL;
if (ret > 0 && ret != vdev->nr_vectors) { if (ret > 0) {
vdev->nr_vectors = ret; vdev->nr_vectors = ret;
goto retry; goto retry;
} }