mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests/avocado: Disable the test_sbsaref_edk2_firmware by default

Browse Source 
The test fails occasionally, see e.g.:

 https://gitlab.com/thuth/qemu/-/jobs/4196177756#L489
 https://gitlab.com/thuth/qemu/-/jobs/4623296271#L290

It also fails on my laptop in ca. 50% of all runs. Thus disable it by
default by using the QEMU_TEST_FLAKY_TESTS environment variable to fence
it (which we also already use in flaky qtests). While we're at it, also
document this variable in docs/devel/testing.rst.

Message-Id: <20230710170155.7192-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Thomas Huth 2023-07-10 19:01:55 +02:00
parent ca2a07f6c3
commit a5754847e0
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/devel/testing.rst
View File

@ -1384,6 +1384,11 @@ variable as shown on the code snippet below to skip the test:
def test(self): def test(self):
do_something() do_something()
QEMU_TEST_FLAKY_TESTS
^^^^^^^^^^^^^^^^^^^^^
Some tests are not working reliably and thus are disabled by default.
Set this environment variable to enable them.
Uninstalling Avocado Uninstalling Avocado
~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~

2
tests/avocado/machine_aarch64_sbsaref.py
View File

@ -8,7 +8,6 @@
import os import os
from avocado import skip
from avocado import skipUnless from avocado import skipUnless
from avocado.utils import archive from avocado.utils import archive
@ -76,6 +75,7 @@ class Aarch64SbsarefMachine(QemuSystemTest):
"sbsa-ref", "sbsa-ref",
) )
@skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is not reliable')
def test_sbsaref_edk2_firmware(self): def test_sbsaref_edk2_firmware(self):
""" """
:avocado: tags=cpu:cortex-a57 :avocado: tags=cpu:cortex-a57