mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/core: Improve error message when machine doesn't provide NMIs

Browse Source 
The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.

Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague
error message

    (qemu) nmi
    Error: this feature or command is not currently supported

to

    Error: machine does not provide NMIs

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230207075115.1525-5-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
This commit is contained in:
Markus Armbruster 2023-02-07 08:51:07 +01:00
parent f1a4697c23
commit a0d0267779
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/core/nmi.c
View File

@ -22,7 +22,6 @@
#include "qemu/osdep.h" #include "qemu/osdep.h"
#include "hw/nmi.h" #include "hw/nmi.h"
#include "qapi/error.h" #include "qapi/error.h"
#include "qapi/qmp/qerror.h"
#include "qemu/module.h" #include "qemu/module.h"
#include "monitor/monitor.h" #include "monitor/monitor.h"
@ -70,7 +69,7 @@ void nmi_monitor_handle(int cpu_index, Error **errp)
if (ns.handled) { if (ns.handled) {
error_propagate(errp, ns.err); error_propagate(errp, ns.err);
} else { } else {
error_setg(errp, QERR_UNSUPPORTED); error_setg(errp, "machine does not provide NMIs");
} }
} }