mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

block-migration: fix blk_mig_save_dirty_block() return value checking

Browse Source 
Commit 43be3a25c9 changed the
blk_mig_save_dirty_block() return code handling.  The function's doc
comment says:

  /* return value:
   * 0: too much data for max_downtime
   * 1: few enough data for max_downtime
   */

Because of the 1 return value, callers must check for ret < 0 instead of
just:

  if (ret) { ... }

We do not want to bail when 1 is returned, only on error.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 1360534366-26723-3-git-send-email-stefanha@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Stefan Hajnoczi 2013-02-10 23:12:45 +01:00 committed by Anthony Liguori
parent d5f1f286ef
commit 9ee0cb201e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
block-migration.c
View File

@ -569,7 +569,7 @@ static int block_save_iterate(QEMUFile *f, void *opaque)
}
}
}
if (ret) {
if (ret < 0) {
blk_mig_cleanup();
return ret;
}
@ -609,7 +609,7 @@ static int block_save_complete(QEMUFile *f, void *opaque)
} while (ret == 0);
blk_mig_cleanup();
if (ret) {
if (ret < 0) {
return ret;
}
/* report completion */