mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

virtiofsd: Fix security.capability comparison

Browse Source 
My security fix for the security.capability remap has a silly early
segfault in a simple case where there is an xattrmapping but it doesn't
remap the security.capability.

Fixes: e586edcb41 ("virtiofs: drop remapped security.capability xattr as needed")
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20210401145845.78445-1-dgilbert@redhat.com>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
This commit is contained in:
Dr. David Alan Gilbert 2021-04-01 15:58:45 +01:00
parent d0d3dd401b
commit 99c3ac6dbe
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/virtiofsd/passthrough_ll.c
View File

@ -2636,7 +2636,8 @@ static void parse_xattrmap(struct lo_data *lo)
strerror(ret)); strerror(ret));
exit(1); exit(1);
} }
if (!strcmp(lo->xattr_security_capability, "security.capability")) { if (!lo->xattr_security_capability ||
!strcmp(lo->xattr_security_capability, "security.capability")) {
/* 1-1 mapping, don't need to do anything */ /* 1-1 mapping, don't need to do anything */
free(lo->xattr_security_capability); free(lo->xattr_security_capability);
lo->xattr_security_capability = NULL; lo->xattr_security_capability = NULL;