mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

savevm: Fix load_snapshot error path crash

Browse Source 
An error path missed setting *errp, which can cause a NULL deref.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Message-Id: <20240813050638.446172-11-npiggin@gmail.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240813202329.1237572-19-alex.bennee@linaro.org>
This commit is contained in:
Nicholas Piggin 2024-08-13 21:23:26 +01:00 committed by Alex Bennée
parent 44bc14fa1e
commit 97d2b66dcd
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
migration/savevm.c
View File

@ -3288,6 +3288,7 @@ bool load_snapshot(const char *name, const char *vmstate,
/* Don't even try to load empty VM states */ /* Don't even try to load empty VM states */
ret = bdrv_snapshot_find(bs_vm_state, &sn, name); ret = bdrv_snapshot_find(bs_vm_state, &sn, name);
if (ret < 0) { if (ret < 0) {
error_setg(errp, "Snapshot can not be found");
return false; return false;
} else if (sn.vm_state_size == 0) { } else if (sn.vm_state_size == 0) {
error_setg(errp, "This is a disk-only snapshot. Revert to it " error_setg(errp, "This is a disk-only snapshot. Revert to it "