mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu_ldst.h: Use inline functions for usermode cpu_ld/st accessors

Browse Source 
Use inline functions rather than macros for cpu_ld/st accessors
for the *-user configurations, as we already do for softmmu.
This has a two advantages:
 * we can actually typecheck our arguments
 * we don't need to leak the _raw macros everywhere

Since the _kernel functions were only used by target-i386/seg_helper.c,
put the definitions for them in that file too. (It already has the
similar template include code to define them for the softmmu case,
so it makes sense to have it deal with defining them for user-only.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 1421334118-3287-12-git-send-email-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2015-01-20 15:19:34 +00:00
parent 177ea79f65
commit 9220fe54c6
3 changed files with 120 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
include/exec/cpu_ldst.h
View File

@ -78,47 +78,39 @@
#define stfl_raw(p, v) stfl_p(saddr((p)), v) #define stfl_raw(p, v) stfl_p(saddr((p)), v)
#define stfq_raw(p, v) stfq_p(saddr((p)), v) #define stfq_raw(p, v) stfq_p(saddr((p)), v)
#if defined(CONFIG_USER_ONLY) #if defined(CONFIG_USER_ONLY)
/* if user mode, no other memory access functions */ /* In user-only mode we provide only the _code and _data accessors. */
#define cpu_ldub_code(env1, p) ldub_raw(p) #define MEMSUFFIX _data
#define cpu_ldsb_code(env1, p) ldsb_raw(p) #define DATA_SIZE 1
#define cpu_lduw_code(env1, p) lduw_raw(p) #include "exec/cpu_ldst_useronly_template.h"
#define cpu_ldsw_code(env1, p) ldsw_raw(p)
#define cpu_ldl_code(env1, p) ldl_raw(p)
#define cpu_ldq_code(env1, p) ldq_raw(p)
#define cpu_ldub_data(env, addr) ldub_raw(addr) #define DATA_SIZE 2
#define cpu_lduw_data(env, addr) lduw_raw(addr) #include "exec/cpu_ldst_useronly_template.h"
#define cpu_ldsw_data(env, addr) ldsw_raw(addr)
#define cpu_ldl_data(env, addr) ldl_raw(addr)
#define cpu_ldq_data(env, addr) ldq_raw(addr)
#define cpu_stb_data(env, addr, data) stb_raw(addr, data) #define DATA_SIZE 4
#define cpu_stw_data(env, addr, data) stw_raw(addr, data) #include "exec/cpu_ldst_useronly_template.h"
#define cpu_stl_data(env, addr, data) stl_raw(addr, data)
#define cpu_stq_data(env, addr, data) stq_raw(addr, data)
#define cpu_ldub_kernel(env, addr) ldub_raw(addr) #define DATA_SIZE 8
#define cpu_lduw_kernel(env, addr) lduw_raw(addr) #include "exec/cpu_ldst_useronly_template.h"
#define cpu_ldsw_kernel(env, addr) ldsw_raw(addr) #undef MEMSUFFIX
#define cpu_ldl_kernel(env, addr) ldl_raw(addr)
#define cpu_ldq_kernel(env, addr) ldq_raw(addr)
#define cpu_stb_kernel(env, addr, data) stb_raw(addr, data) #define MEMSUFFIX _code
#define cpu_stw_kernel(env, addr, data) stw_raw(addr, data) #define CODE_ACCESS
#define cpu_stl_kernel(env, addr, data) stl_raw(addr, data) #define DATA_SIZE 1
#define cpu_stq_kernel(env, addr, data) stq_raw(addr, data) #include "exec/cpu_ldst_useronly_template.h"
#define cpu_ldub_data(env, addr) ldub_raw(addr) #define DATA_SIZE 2
#define cpu_lduw_data(env, addr) lduw_raw(addr) #include "exec/cpu_ldst_useronly_template.h"
#define cpu_ldl_data(env, addr) ldl_raw(addr)
#define cpu_stb_data(env, addr, data) stb_raw(addr, data) #define DATA_SIZE 4
#define cpu_stw_data(env, addr, data) stw_raw(addr, data) #include "exec/cpu_ldst_useronly_template.h"
#define cpu_stl_data(env, addr, data) stl_raw(addr, data)
#define DATA_SIZE 8
#include "exec/cpu_ldst_useronly_template.h"
#undef MEMSUFFIX
#undef CODE_ACCESS
#else #else

81
include/exec/cpu_ldst_useronly_template.h Normal file
View File

@ -0,0 +1,81 @@
/*
* User-only accessor function support
*
* Generate inline load/store functions for one data size.
*
* Generate a store function as well as signed and unsigned loads.
*
* Not used directly but included from cpu_ldst.h.
*
* Copyright (c) 2015 Linaro Limited
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#if DATA_SIZE == 8
#define SUFFIX q
#define USUFFIX q
#define DATA_TYPE uint64_t
#elif DATA_SIZE == 4
#define SUFFIX l
#define USUFFIX l
#define DATA_TYPE uint32_t
#elif DATA_SIZE == 2
#define SUFFIX w
#define USUFFIX uw
#define DATA_TYPE uint16_t
#define DATA_STYPE int16_t
#elif DATA_SIZE == 1
#define SUFFIX b
#define USUFFIX ub
#define DATA_TYPE uint8_t
#define DATA_STYPE int8_t
#else
#error unsupported data size
#endif
#if DATA_SIZE == 8
#define RES_TYPE uint64_t
#else
#define RES_TYPE uint32_t
#endif
static inline RES_TYPE
glue(glue(cpu_ld, USUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong ptr)
{
return glue(glue(ld, USUFFIX), _p)(g2h(ptr));
}
#if DATA_SIZE <= 2
static inline int
glue(glue(cpu_lds, SUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong ptr)
{
return glue(glue(lds, SUFFIX), _p)(g2h(ptr));
}
#endif
#ifndef CODE_ACCESS
static inline void
glue(glue(cpu_st, SUFFIX), MEMSUFFIX)(CPUArchState *env, target_ulong ptr,
RES_TYPE v)
{
glue(glue(st, SUFFIX), _p)(g2h(ptr), v);
}
#endif
#undef RES_TYPE
#undef DATA_TYPE
#undef DATA_STYPE
#undef SUFFIX
#undef USUFFIX
#undef DATA_SIZE

16
target-i386/seg_helper.c
View File

@ -34,7 +34,21 @@
# define LOG_PCALL_STATE(cpu) do { } while (0) # define LOG_PCALL_STATE(cpu) do { } while (0)
#endif #endif
#ifndef CONFIG_USER_ONLY #ifdef CONFIG_USER_ONLY
#define MEMSUFFIX _kernel
#define DATA_SIZE 1
#include "exec/cpu_ldst_useronly_template.h"
#define DATA_SIZE 2
#include "exec/cpu_ldst_useronly_template.h"
#define DATA_SIZE 4
#include "exec/cpu_ldst_useronly_template.h"
#define DATA_SIZE 8
#include "exec/cpu_ldst_useronly_template.h"
#undef MEMSUFFIX
#else
#define CPU_MMU_INDEX (cpu_mmu_index_kernel(env)) #define CPU_MMU_INDEX (cpu_mmu_index_kernel(env))
#define MEMSUFFIX _kernel #define MEMSUFFIX _kernel
#define DATA_SIZE 1 #define DATA_SIZE 1