From 906fb135e4b875465c424cb9b2b47d90265f7897 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Tue, 9 Aug 2016 17:47:42 +0200 Subject: [PATCH] checkpatch: tweak the files in which TABs are checked Include Python and shell scripts, and make an exception for Perl scripts we imported from Linux or elsewhere. Acked-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 8d1813eef6..082c4cecc9 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1334,7 +1334,7 @@ sub process { } # check we are in a valid source file if not then ignore this hunk - next if ($realfile !~ /\.(h|c|cpp|s|S|pl|sh)$/); + next if ($realfile !~ /\.(h|c|cpp|s|S|pl|py|sh)$/); #80 column limit if ($line =~ /^\+/ && @@ -1354,10 +1354,11 @@ sub process { WARN("adding a line without newline at end of file\n" . $herecurr); } -# check we are in a valid source file C or perl if not then ignore this hunk - next if ($realfile !~ /\.(h|c|cpp|pl)$/); +# tabs are only allowed in assembly source code, and in +# some scripts we imported from other projects. + next if ($realfile =~ /\.(s|S)$/); + next if ($realfile =~ /(checkpatch|get_maintainer|texi2pod)\.pl$/); -# in QEMU, no tabs are allowed if ($rawline =~ /^\+.*\t/) { my $herevet = "$here\n" . cat_vet($rawline) . "\n"; ERROR("code indent should never use tabs\n" . $herevet);