mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/readline: Fix lints for readline_handle_byte

Browse Source 
While they do not give warnings under our current buildsystem
configuration, my clang's language server daemon was complaining about
missing default: labels in switch statements.

While at it, add /* fallthrough */ annotations where appropriate.

This is a purely style and not functional change.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <16f745ac7f5fef74498709ffd98857e76edff6aa.1718265822.git.manos.pitsidianakis@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Manos Pitsidianakis 2024-06-13 11:06:11 +03:00 committed by Philippe Mathieu-Daudé
parent 4860af2c4f
commit 9051350d25
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
util/readline.c
View File

@ -405,7 +405,7 @@ void readline_handle_byte(ReadLineState *rs, int ch)
case 12:
readline_clear_screen(rs);
break;
case 10:
case 10: /* fallthrough */
case 13:
rs->cmd_buf[rs->cmd_buf_size] = '\0';
if (!rs->read_password) {
@ -425,7 +425,7 @@ void readline_handle_byte(ReadLineState *rs, int ch)
case 27:
rs->esc_state = IS_ESC;
break;
case 127:
case 127: /* fallthrough */
case 8:
readline_backspace(rs);
break;
@ -452,11 +452,11 @@ void readline_handle_byte(ReadLineState *rs, int ch)
break;
case IS_CSI:
switch (ch) {
case 'A':
case 'A': /* fallthrough */
case 'F':
readline_up_char(rs);
break;
case 'B':
case 'B': /* fallthrough */
case 'E':
readline_down_char(rs);
break;
@ -480,12 +480,15 @@ void readline_handle_byte(ReadLineState *rs, int ch)
case 4:
readline_eol(rs);
break;
default:
break;
}
break;
default:
break;
}
rs->esc_state = IS_NORM;
/* fallthrough */
the_end:
break;
case IS_SS3:
@ -496,9 +499,13 @@ void readline_handle_byte(ReadLineState *rs, int ch)
case 'H':
readline_bol(rs);
break;
default:
break;
}
rs->esc_state = IS_NORM;
break;
default:
break;
}
readline_update(rs);
}