mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

accel: remove dead statement and useless assertion

Browse Source 
ops is assigned again just below, and the result of the assignment must
be non-NULL.

Originally, the check for NULL was meant to be a check for the existence
of the ops class:

    ops = ACCEL_OPS_CLASS(object_class_by_name(ops_name));
    ...
    g_assert(ops != NULL);

(where the ops assignment begot the one that I am removing); but this is
meaningless now that oc is checked to be non-NULL before ops is assigned
(commit 5141e9a23f, "accel: abort if we fail to load the accelerator
plugin", 2022-11-06).

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2024-10-29 10:43:16 +01:00
parent 3139ad088b
commit 8aade934df
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
accel/accel-system.c
View File

@ -73,19 +73,17 @@ void accel_system_init_ops_interfaces(AccelClass *ac)
g_assert(ac_name != NULL); g_assert(ac_name != NULL);
ops_name = g_strdup_printf("%s" ACCEL_OPS_SUFFIX, ac_name); ops_name = g_strdup_printf("%s" ACCEL_OPS_SUFFIX, ac_name);
ops = ACCEL_OPS_CLASS(module_object_class_by_name(ops_name));
oc = module_object_class_by_name(ops_name); oc = module_object_class_by_name(ops_name);
if (!oc) { if (!oc) {
error_report("fatal: could not load module for type '%s'", ops_name); error_report("fatal: could not load module for type '%s'", ops_name);
exit(1); exit(1);
} }
g_free(ops_name); g_free(ops_name);
ops = ACCEL_OPS_CLASS(oc);
/* /*
* all accelerators need to define ops, providing at least a mandatory * all accelerators need to define ops, providing at least a mandatory
* non-NULL create_vcpu_thread operation. * non-NULL create_vcpu_thread operation.
*/ */
g_assert(ops != NULL); ops = ACCEL_OPS_CLASS(oc);
if (ops->ops_init) { if (ops->ops_init) {
ops->ops_init(ops); ops->ops_init(ops);
} }