mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device-crash-test: Check if path is actually an executable file

Browse Source 
After the transition to Meson, the build directory now have
subdirectories named "qemu-system-*.p", and device-crash-test
will try to execute them as if they were binaries.  This results
in errors like:

  PermissionError: [Errno 13] Permission denied: './qemu-system-or1k.p'

When generating the default list of binaries to test, check if
the path is actually a file and if it's executable.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20201026125238.2752882-1-ehabkost@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Eduardo Habkost 2020-10-26 08:52:38 -04:00 committed by Thomas Huth
parent 45716765b1
commit 8a47836548
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/device-crash-test
View File

@ -383,7 +383,9 @@ def binariesToTest(args, testcase):
if args.qemu: if args.qemu:
r = args.qemu r = args.qemu
else: else:
r = glob.glob('./qemu-system-*') r = [f.path for f in os.scandir('.')
if f.name.startswith('qemu-system-') and
f.is_file() and os.access(f, os.X_OK)]
return r return r