mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vnc: explain why set_encodings loop is reversed

Browse Source 
Add a small comment to explain why we need to start from
the end of the array to set the right prefered encoding.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Corentin Chary 2010-05-19 09:24:02 +02:00 committed by Anthony Liguori
parent a9f20d31a8
commit 8a0f0d0ca3
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
vnc.c
View File

@ -1649,6 +1649,11 @@ static void set_encodings(VncState *vs, int32_t *encodings, size_t n_encodings)
vs->tight_quality = 9; vs->tight_quality = 9;
vs->absolute = -1; vs->absolute = -1;
/*
* Start from the end because the encodings are sent in order of preference.
* This way the prefered encoding (first encoding defined in the array)
* will be set at the end of the loop.
*/
for (i = n_encodings - 1; i >= 0; i--) { for (i = n_encodings - 1; i >= 0; i--) {
enc = encodings[i]; enc = encodings[i];
switch (enc) { switch (enc) {