mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

memory: Store physical root MR in FlatView

Browse Source 
Address spaces get to keep a root MR (alias or not) but FlatView stores
the actual MR as this is going to be used later on to decide whether to
share a particular FlatView or not.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-Id: <20170921085110.25598-10-aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Alexey Kardashevskiy 2017-09-21 18:51:01 +10:00 committed by Paolo Bonzini
parent 8629d3fcb7
commit 89c177bbdd
1 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
memory.c
View File

@ -230,6 +230,7 @@ struct FlatView {
unsigned nr; unsigned nr;
unsigned nr_allocated; unsigned nr_allocated;
struct AddressSpaceDispatch *dispatch; struct AddressSpaceDispatch *dispatch;
MemoryRegion *root;
}; };
typedef struct AddressSpaceOps AddressSpaceOps; typedef struct AddressSpaceOps AddressSpaceOps;
@ -259,12 +260,14 @@ static bool flatrange_equal(FlatRange *a, FlatRange *b)
&& a->readonly == b->readonly; && a->readonly == b->readonly;
} }
static FlatView *flatview_new(void) static FlatView *flatview_new(MemoryRegion *mr_root)
{ {
FlatView *view; FlatView *view;
view = g_new0(FlatView, 1); view = g_new0(FlatView, 1);
view->ref = 1; view->ref = 1;
view->root = mr_root;
memory_region_ref(mr_root);
return view; return view;
} }
@ -297,6 +300,7 @@ static void flatview_destroy(FlatView *view)
memory_region_unref(view->ranges[i].mr); memory_region_unref(view->ranges[i].mr);
} }
g_free(view->ranges); g_free(view->ranges);
memory_region_unref(view->root);
g_free(view); g_free(view);
} }
@ -723,12 +727,25 @@ static void render_memory_region(FlatView *view,
} }
} }
static MemoryRegion *memory_region_get_flatview_root(MemoryRegion *mr)
{
while (mr->alias && !mr->alias_offset &&
int128_ge(mr->size, mr->alias->size)) {
/* The alias is included in its entirety. Use it as
* the "real" root, so that we can share more FlatViews.
*/
mr = mr->alias;
}
return mr;
}
/* Render a memory topology into a list of disjoint absolute ranges. */ /* Render a memory topology into a list of disjoint absolute ranges. */
static FlatView *generate_memory_topology(MemoryRegion *mr) static FlatView *generate_memory_topology(MemoryRegion *mr)
{ {
FlatView *view; FlatView *view;
view = flatview_new(); view = flatview_new(mr);
if (mr) { if (mr) {
render_memory_region(view, mr, int128_zero(), render_memory_region(view, mr, int128_zero(),
@ -907,7 +924,8 @@ static void address_space_update_topology_pass(AddressSpace *as,
static void address_space_update_topology(AddressSpace *as) static void address_space_update_topology(AddressSpace *as)
{ {
FlatView *old_view = address_space_get_flatview(as); FlatView *old_view = address_space_get_flatview(as);
FlatView *new_view = generate_memory_topology(as->root); MemoryRegion *physmr = memory_region_get_flatview_root(old_view->root);
FlatView *new_view = generate_memory_topology(physmr);
int i; int i;
new_view->dispatch = address_space_dispatch_new(new_view); new_view->dispatch = address_space_dispatch_new(new_view);
@ -2650,7 +2668,7 @@ void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name)
as->ref_count = 1; as->ref_count = 1;
as->root = root; as->root = root;
as->malloced = false; as->malloced = false;
as->current_map = flatview_new(); as->current_map = flatview_new(root);
as->ioeventfd_nb = 0; as->ioeventfd_nb = 0;
as->ioeventfds = NULL; as->ioeventfds = NULL;
QTAILQ_INIT(&as->listeners); QTAILQ_INIT(&as->listeners);