mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nbd/client: fix nbd_negotiate_simple_meta_context

Browse Source 
Initialize received variable. Otherwise, is is possible for server to
answer without any contexts, but we will set context_id to something
random (received_id is not initialized too) and return 1, which is
wrong.

To solve it, just initialize received to false. Initialize received_id
too, just to make all possible checkers happy.

Bug was introduced in 78a33ab587 "nbd: BLOCK_STATUS for
standard get_block_status function: client part" with the whole
function.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20180427142002.21930-2-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Vladimir Sementsov-Ogievskiy 2018-04-27 17:20:01 +03:00 committed by Eric Blake
parent 26bd8d98c4
commit 89aa0d8763
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nbd/client.c
View File

@ -613,8 +613,8 @@ static int nbd_negotiate_simple_meta_context(QIOChannel *ioc,
{ {
int ret; int ret;
NBDOptionReply reply; NBDOptionReply reply;
uint32_t received_id; uint32_t received_id = 0;
bool received; bool received = false;
uint32_t export_len = strlen(export); uint32_t export_len = strlen(export);
uint32_t context_len = strlen(context); uint32_t context_len = strlen(context);
uint32_t data_len = sizeof(export_len) + export_len + uint32_t data_len = sizeof(export_len) + export_len +