mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

memory: fix 'info mtree' segfaults

Browse Source 
'info mtree' accesses invalid memory in two cases, both due to incorrect
(and unsafe) usage of QTAILQ_FOREACH_SAFE().

Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Avi Kivity <avi@redhat.com>
This commit is contained in:
Avi Kivity 2011-11-13 12:00:55 +02:00
parent 74d33d5ce4
commit 88365e47dd
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
memory.c
View File

@ -1401,7 +1401,7 @@ static void mtree_print_mr(fprintf_function mon_printf, void *f,
alias_print_queue); alias_print_queue);
} }
QTAILQ_FOREACH_SAFE(next_ml, &submr_print_queue, queue, ml) { QTAILQ_FOREACH_SAFE(ml, &submr_print_queue, queue, next_ml) {
g_free(ml); g_free(ml);
} }
} }
@ -1425,7 +1425,7 @@ void mtree_info(fprintf_function mon_printf, void *f)
} }
QTAILQ_FOREACH_SAFE(ml, &ml_head, queue, ml2) { QTAILQ_FOREACH_SAFE(ml, &ml_head, queue, ml2) {
g_free(ml2); g_free(ml);
} }
if (address_space_io.root && if (address_space_io.root &&