mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/mips: Handle lock_user() failure in UHI_plog semihosting call

Browse Source 
Coverity notes that we forgot to check the error return from
lock_user() in one place in the handling of the UHI_plog semihosting
call.  Add the missing error handling.

report_fault() is rather brutal in that it will call abort(), but
this is the same error-handling used in the rest of this file.

Resolves: Coverity CID 1490684
Fixes: ea4210600d ("target/mips: Avoid qemu_semihosting_log_out for UHI_plog")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220719191737.384744-1-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
This commit is contained in:
Peter Maydell 2022-07-19 20:17:37 +01:00 committed by Philippe Mathieu-Daudé
parent 8a1337e604
commit 8809baf4e4
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
target/mips/tcg/sysemu/mips-semi.c
View File

@ -321,6 +321,9 @@ void mips_semihosting(CPUMIPSState *env)
if (use_gdb_syscalls()) { if (use_gdb_syscalls()) {
addr = gpr[29] - str->len; addr = gpr[29] - str->len;
p = lock_user(VERIFY_WRITE, addr, str->len, 0); p = lock_user(VERIFY_WRITE, addr, str->len, 0);
if (!p) {
report_fault(env);
}
memcpy(p, str->str, str->len); memcpy(p, str->str, str->len);
unlock_user(p, addr, str->len); unlock_user(p, addr, str->len);
semihost_sys_write(cs, uhi_cb, 2, addr, str->len); semihost_sys_write(cs, uhi_cb, 2, addr, str->len);