mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

virtio-blk: declare VirtIOBlock::rq with a type

Browse Source 
The VirtIOBlock::rq field has had the type void * since its introduction
in commit 869a5c6df1 ("Stop VM on error in virtio-blk. (Gleb
Natapov)").

Perhaps this was done to avoid the forward declaration of
VirtIOBlockReq.

Hanna Czenczek <hreitz@redhat.com> pointed out the missing type. Specify
the actual type because there is no need to use void * here.

Suggested-by: Hanna Czenczek <hreitz@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20240206190610.107963-5-stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Stefan Hajnoczi 2024-02-06 14:06:09 -05:00 committed by Kevin Wolf
parent f2eea93c6b
commit 8802f4f4e3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/hw/virtio/virtio-blk.h
View File

@ -55,7 +55,7 @@ struct VirtIOBlock {
VirtIODevice parent_obj; VirtIODevice parent_obj;
BlockBackend *blk; BlockBackend *blk;
QemuMutex rq_lock; QemuMutex rq_lock;
void *rq; /* protected by rq_lock */ struct VirtIOBlockReq *rq; /* protected by rq_lock */
VirtIOBlkConf conf; VirtIOBlkConf conf;
unsigned short sector_mask; unsigned short sector_mask;
bool original_wce; bool original_wce;