From 866c72bbb886293d26e01ef7ee4277ebd27c9efd Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Fri, 31 Jul 2009 15:15:41 -0300 Subject: [PATCH] Fix do_commit() behavior Commit 751c6a17042b5d011013d6963c0505d671cf708e changed the monitor's 'commit' command to this behavior: 1. Any string you type as argument will cause do_commit() to call bdrv_commit() to all devices 2. If you enter a device name, it will be the only one ignored by do_commit() :) The fix is to call bdrv_commit() to the specified device only and ignore the others (when 'all' is not specified). Signed-off-by: Luiz Capitulino Signed-off-by: Anthony Liguori --- monitor.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 3816d09c18..de68755020 100644 --- a/monitor.c +++ b/monitor.c @@ -257,9 +257,10 @@ static void do_commit(Monitor *mon, const char *device) all_devices = !strcmp(device, "all"); for (i = 0; i < nb_drives; i++) { - if (all_devices || - !strcmp(bdrv_get_device_name(drives_table[i].bdrv), device)) - bdrv_commit(drives_table[i].bdrv); + if (!all_devices) + if (strcmp(bdrv_get_device_name(drives_table[i].bdrv), device)) + continue; + bdrv_commit(drives_table[i].bdrv); } }