python: Remove global pylint suppressions
These suppressions only apply to a small handful of places. Instead of disabling them globally, disable them just in the cases where we need. The design of the machine class grew quite organically with tons of constructor and class instance variables -- there's little chance of meaningfully refactoring it in the near term, so just suppress the warnings for that class. Signed-off-by: John Snow <jsnow@redhat.com> Reviewed-by: Willian Rampazzo <willianr@redhat.com> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> Message-id: 20210629214323.1329806-4-jsnow@redhat.com Signed-off-by: John Snow <jsnow@redhat.com>
This commit is contained in:
parent
7f17908263
commit
82e6517d9d
@ -84,6 +84,7 @@ class QEMUMachine:
|
||||
...
|
||||
# vm is guaranteed to be shut down here
|
||||
"""
|
||||
# pylint: disable=too-many-instance-attributes, too-many-public-methods
|
||||
|
||||
def __init__(self,
|
||||
binary: str,
|
||||
@ -111,6 +112,8 @@ class QEMUMachine:
|
||||
@param console_log: (optional) path to console log file
|
||||
@note: Qemu process is not started until launch() is used.
|
||||
'''
|
||||
# pylint: disable=too-many-arguments
|
||||
|
||||
# Direct user configuration
|
||||
|
||||
self._binary = binary
|
||||
|
@ -116,6 +116,8 @@ class QEMUQtestMachine(QEMUMachine):
|
||||
base_temp_dir: str = "/var/tmp",
|
||||
socket_scm_helper: Optional[str] = None,
|
||||
sock_dir: Optional[str] = None):
|
||||
# pylint: disable=too-many-arguments
|
||||
|
||||
if name is None:
|
||||
name = "qemu-%d" % os.getpid()
|
||||
if sock_dir is None:
|
||||
|
@ -87,9 +87,7 @@ ignore_missing_imports = True
|
||||
# --enable=similarities". If you want to run only the classes checker, but have
|
||||
# no Warning level messages displayed, use "--disable=all --enable=classes
|
||||
# --disable=W".
|
||||
disable=too-many-arguments,
|
||||
too-many-instance-attributes,
|
||||
too-many-public-methods,
|
||||
disable=
|
||||
|
||||
[pylint.basic]
|
||||
# Good variable names which should always be accepted, separated by a comma.
|
||||
|
Loading…
Reference in New Issue
Block a user