mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pci-assign: Fix potential read beyond buffer on -EBUSY

Browse Source 
readlink() doesn't write a terminating null byte.
assign_failed_examine() passes the unterminated string to strrchr().
Oops.  Terminate it.

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
Markus Armbruster 2014-02-26 10:30:03 -07:00 committed by Alex Williamson
parent 13665a2d2f
commit 82d0794565
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hw/i386/kvm/pci-assign.c
View File

@ -743,6 +743,7 @@ static void assign_failed_examine(AssignedDevice *dev)
goto fail; goto fail;
} }
driver[r] = 0;
ns = strrchr(driver, '/'); ns = strrchr(driver, '/');
if (!ns) { if (!ns) {
goto fail; goto fail;