mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

q800: fix coverity warning CID 1412799

Browse Source 
Check the return value of blk_write() and log an error if any

Fixes: Coverity CID 1412799 (Error handling issues)
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200210132252.381343-1-laurent@vivier.eu>
This commit is contained in:
Laurent Vivier 2020-02-10 14:22:52 +01:00
parent 104933c4a9
commit 80aab795f8
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hw/misc/mac_via.c
View File

@ -30,6 +30,7 @@
#include "hw/qdev-properties.h" #include "hw/qdev-properties.h"
#include "sysemu/block-backend.h" #include "sysemu/block-backend.h"
#include "trace.h" #include "trace.h"
#include "qemu/log.h"
/* /*
* VIAs: There are two in every machine, * VIAs: There are two in every machine,
@ -381,8 +382,10 @@ static void via2_irq_request(void *opaque, int irq, int level)
static void pram_update(MacVIAState *m) static void pram_update(MacVIAState *m)
{ {
if (m->blk) { if (m->blk) {
blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM, if (blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM,
sizeof(m->mos6522_via1.PRAM), 0); sizeof(m->mos6522_via1.PRAM), 0) < 0) {
qemu_log("pram_update: cannot write to file\n");
}
} }
} }