mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

block/vvfat: inherit child_vvfat_qcow from child_of_bds

Browse Source 
Recently we've fixed a crash by adding .get_parent_aio_context handler
to child_vvfat_qcow. Now we want it to support .get_parent_desc as
well. child_vvfat_qcow wants to implement own .inherit_options, it's
not bad. But omitting all other handlers is a bad idea. Let's inherit
the class from child_of_bds instead, similar to chain_child_class and
detach_by_driver_cb_class in test-bdrv-drain.c.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210601075218.79249-5-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Vladimir Sementsov-Ogievskiy 2021-06-01 10:52:16 +03:00 committed by Kevin Wolf
parent 2c0a3acb95
commit 8081f064e4
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
block/vvfat.c
View File

@ -3127,11 +3127,7 @@ static void vvfat_qcow_options(BdrvChildRole role, bool parent_is_format,
qdict_set_default_str(child_options, BDRV_OPT_CACHE_NO_FLUSH, "on"); qdict_set_default_str(child_options, BDRV_OPT_CACHE_NO_FLUSH, "on");
} }
static const BdrvChildClass child_vvfat_qcow = { static BdrvChildClass child_vvfat_qcow;
.parent_is_bds = true,
.inherit_options = vvfat_qcow_options,
.get_parent_aio_context = child_of_bds_get_parent_aio_context,
};
static int enable_write_target(BlockDriverState *bs, Error **errp) static int enable_write_target(BlockDriverState *bs, Error **errp)
{ {
@ -3268,6 +3264,8 @@ static BlockDriver bdrv_vvfat = {
static void bdrv_vvfat_init(void) static void bdrv_vvfat_init(void)
{ {
child_vvfat_qcow = child_of_bds;
child_vvfat_qcow.inherit_options = vvfat_qcow_options;
bdrv_register(&bdrv_vvfat); bdrv_register(&bdrv_vvfat);
} }