mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd()

Browse Source 
Here we don't expect a failure. In case of failure we'll crash on
trying to access ['return']. Better is to use .command() that clearly
raises on failure.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20231006154125.1068348-4-vsementsov@yandex-team.ru
Signed-off-by: John Snow <jsnow@redhat.com>
This commit is contained in:
Vladimir Sementsov-Ogievskiy 2023-10-06 18:41:13 +03:00 committed by John Snow
parent 2cee9ca97d
commit 7f521b023b
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/cpu-x86-uarch-abi.py
View File

@ -69,7 +69,7 @@ sock = sys.argv[1]
shell = QEMUMonitorProtocol(sock) shell = QEMUMonitorProtocol(sock)
shell.connect() shell.connect()
models = shell.cmd("query-cpu-definitions") models = shell.command("query-cpu-definitions")
# These QMP props don't correspond to CPUID fatures # These QMP props don't correspond to CPUID fatures
# so ignore them # so ignore them
@ -85,7 +85,7 @@ skip = [
names = [] names = []
for model in models["return"]: for model in models:
if "alias-of" in model: if "alias-of" in model:
continue continue
names.append(model["name"]) names.append(model["name"])
@ -93,12 +93,12 @@ for model in models["return"]:
models = {} models = {}
for name in sorted(names): for name in sorted(names):
cpu = shell.cmd("query-cpu-model-expansion", cpu = shell.command("query-cpu-model-expansion",
{ "type": "static", { "type": "static",
"model": { "name": name }}) "model": { "name": name }})
got = {} got = {}
for (feature, present) in cpu["return"]["model"]["props"].items(): for (feature, present) in cpu["model"]["props"].items():
if present and feature not in skip: if present and feature not in skip:
got[feature] = True got[feature] = True