mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/m68k: Drop use of gdb_get_float64() and ldfq_p()

Browse Source 
We used to make a distinction between 'float64'/'float32' types and
the 'uint64_t'/'uint32_t' types, requiring special conversion
operations to go between them.  We've now dropped this distinction as
unnecessary, and the 'float*' types remain primarily for
documentation purposes when used in places like the function
prototypes of TCG helper functions.

This means that there's no need for a special gdb_get_float64()
function to write a float64 value to the GDB protocol buffer; we can
just use gdb_get_reg64().

Similarly, for reading a value out of the GDB buffer into a float64
we can use ldq_p() and need not use ldfq_p().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20210208113428.7181-3-peter.maydell@linaro.org>
Message-Id: <20210211122750.22645-12-alex.bennee@linaro.org>
This commit is contained in:
Peter Maydell 2021-02-11 12:27:46 +00:00 committed by Alex Bennée
parent d20711bd6d
commit 7ed51401f1
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
target/m68k/helper.c
View File

@ -72,8 +72,7 @@ static int cf_fpu_gdb_get_reg(CPUM68KState *env, GByteArray *mem_buf, int n)
{ {
if (n < 8) { if (n < 8) {
float_status s; float_status s;
return gdb_get_float64(mem_buf, return gdb_get_reg64(mem_buf, floatx80_to_float64(env->fregs[n].d, &s));
floatx80_to_float64(env->fregs[n].d, &s));
} }
switch (n) { switch (n) {
case 8: /* fpcontrol */ case 8: /* fpcontrol */
@ -90,7 +89,7 @@ static int cf_fpu_gdb_set_reg(CPUM68KState *env, uint8_t *mem_buf, int n)
{ {
if (n < 8) { if (n < 8) {
float_status s; float_status s;
env->fregs[n].d = float64_to_floatx80(ldfq_p(mem_buf), &s); env->fregs[n].d = float64_to_floatx80(ldq_p(mem_buf), &s);
return 8; return 8;
} }
switch (n) { switch (n) {