mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

replay: fix recursive checkpoints

Browse Source 
Record/replay uses checkpoints to synchronize the execution
of the threads and timers. Hardware events such as BH are
processed at the checkpoints too.
Event processing can cause refreshing the virtual timers
and calling the icount-related functions, that also use checkpoints.
This patch prevents recursive processing of such checkpoints,
because they have their own records in the log and should be
processed later.

Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Message-Id: <161700476500.1140362.10108444973730452257.stgit@pasha-ThinkPad-X280>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Pavel Dovgalyuk 2021-03-29 10:59:25 +03:00 committed by Paolo Bonzini
parent a061a71e0d
commit 7cebff0d03
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
replay/replay.c
View File

@ -180,12 +180,13 @@ bool replay_checkpoint(ReplayCheckpoint checkpoint)
} }
if (in_checkpoint) { if (in_checkpoint) {
/* If we are already in checkpoint, then there is no need /*
for additional synchronization.
Recursion occurs when HW event modifies timers. Recursion occurs when HW event modifies timers.
Timer modification may invoke the checkpoint and Prevent performing icount warp in this case and
proceed to recursion. */ wait for another invocation of the checkpoint.
return true; */
g_assert(replay_mode == REPLAY_MODE_PLAY);
return false;
} }
in_checkpoint = true; in_checkpoint = true;