mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimize the function of filter_send

Browse Source 
The iov_size has been calculated in filter_send(). we can directly
return the size.In this way, this is no need to repeat calculations
in filter_redirector_receive_iov();

Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Tested-by: Lukas Straub <lukasstraub2@web.de>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Rao, Lei 2021-06-08 16:23:27 +08:00 committed by Jason Wang
parent 229620d52e
commit 7c2eae9a77
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
net/filter-mirror.c
View File

@ -88,7 +88,7 @@ static int filter_send(MirrorState *s,
goto err; goto err;
} }
return 0; return size;
err: err:
return ret < 0 ? ret : -EIO; return ret < 0 ? ret : -EIO;
@ -159,7 +159,7 @@ static ssize_t filter_mirror_receive_iov(NetFilterState *nf,
int ret; int ret;
ret = filter_send(s, iov, iovcnt); ret = filter_send(s, iov, iovcnt);
if (ret) { if (ret < 0) {
error_report("filter mirror send failed(%s)", strerror(-ret)); error_report("filter mirror send failed(%s)", strerror(-ret));
} }
@ -182,10 +182,10 @@ static ssize_t filter_redirector_receive_iov(NetFilterState *nf,
if (qemu_chr_fe_backend_connected(&s->chr_out)) { if (qemu_chr_fe_backend_connected(&s->chr_out)) {
ret = filter_send(s, iov, iovcnt); ret = filter_send(s, iov, iovcnt);
if (ret) { if (ret < 0) {
error_report("filter redirector send failed(%s)", strerror(-ret)); error_report("filter redirector send failed(%s)", strerror(-ret));
} }
return iov_size(iov, iovcnt); return ret;
} else { } else {
return 0; return 0;
} }