mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

block: Use bdrv_next() instead of bdrv_states

Browse Source 
There is no point in manually iterating through the bdrv_states list
when there is bdrv_next().

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Max Reitz 2016-03-16 19:54:44 +01:00 committed by Kevin Wolf
parent 2626058034
commit 79720af640
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
block.c
View File

@ -3293,10 +3293,10 @@ void bdrv_invalidate_cache(BlockDriverState *bs, Error **errp)
void bdrv_invalidate_cache_all(Error **errp) void bdrv_invalidate_cache_all(Error **errp)
{ {
BlockDriverState *bs; BlockDriverState *bs = NULL;
Error *local_err = NULL; Error *local_err = NULL;
QTAILQ_FOREACH(bs, &bdrv_states, device_list) { while ((bs = bdrv_next(bs)) != NULL) {
AioContext *aio_context = bdrv_get_aio_context(bs); AioContext *aio_context = bdrv_get_aio_context(bs);
aio_context_acquire(aio_context); aio_context_acquire(aio_context);
@ -3326,10 +3326,10 @@ static int bdrv_inactivate(BlockDriverState *bs)
int bdrv_inactivate_all(void) int bdrv_inactivate_all(void)
{ {
BlockDriverState *bs; BlockDriverState *bs = NULL;
int ret; int ret;
QTAILQ_FOREACH(bs, &bdrv_states, device_list) { while ((bs = bdrv_next(bs)) != NULL) {
AioContext *aio_context = bdrv_get_aio_context(bs); AioContext *aio_context = bdrv_get_aio_context(bs);
aio_context_acquire(aio_context); aio_context_acquire(aio_context);
@ -3835,10 +3835,10 @@ bool bdrv_recurse_is_first_non_filter(BlockDriverState *bs,
*/ */
bool bdrv_is_first_non_filter(BlockDriverState *candidate) bool bdrv_is_first_non_filter(BlockDriverState *candidate)
{ {
BlockDriverState *bs; BlockDriverState *bs = NULL;
/* walk down the bs forest recursively */ /* walk down the bs forest recursively */
QTAILQ_FOREACH(bs, &bdrv_states, device_list) { while ((bs = bdrv_next(bs)) != NULL) {
bool perm; bool perm;
/* try to recurse in this top level bs */ /* try to recurse in this top level bs */