mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Drop superfluous conditionals around g_free()

Browse Source 
There is no need to guard g_free(P) with if (P): g_free(NULL) is safe.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220923090428.93529-1-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Markus Armbruster 2022-09-23 11:04:28 +02:00 committed by Laurent Vivier
parent 90dc46d314
commit 76eb88b12b
3 changed files with 12 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
replay/replay.c
View File

@ -366,10 +366,8 @@ void replay_finish(void)
fclose(replay_file); fclose(replay_file);
replay_file = NULL; replay_file = NULL;
} }
if (replay_filename) {
g_free(replay_filename); g_free(replay_filename);
replay_filename = NULL; replay_filename = NULL;
}
g_free(replay_snapshot); g_free(replay_snapshot);
replay_snapshot = NULL; replay_snapshot = NULL;

4
target/i386/kvm/kvm.c
View File

@ -2176,15 +2176,11 @@ int kvm_arch_destroy_vcpu(CPUState *cs)
g_free(env->xsave_buf); g_free(env->xsave_buf);
if (cpu->kvm_msr_buf) {
g_free(cpu->kvm_msr_buf); g_free(cpu->kvm_msr_buf);
cpu->kvm_msr_buf = NULL; cpu->kvm_msr_buf = NULL;
}
if (env->nested_state) {
g_free(env->nested_state); g_free(env->nested_state);
env->nested_state = NULL; env->nested_state = NULL;
}
qemu_del_vm_change_state_handler(cpu->vmsentry); qemu_del_vm_change_state_handler(cpu->vmsentry);

2
target/i386/whpx/whpx-all.c
View File

@ -1225,14 +1225,12 @@ static void whpx_translate_cpu_breakpoints(
} }
} }
if (breakpoints->breakpoints) {
/* /*
* Free the previous breakpoint list. This can be optimized by keeping * Free the previous breakpoint list. This can be optimized by keeping
* it as shadow buffer for the next computation instead of freeing * it as shadow buffer for the next computation instead of freeing
* it immediately. * it immediately.
*/ */
g_free(breakpoints->breakpoints); g_free(breakpoints->breakpoints);
}
breakpoints->breakpoints = new_breakpoints; breakpoints->breakpoints = new_breakpoints;
} }