mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/display/bcm2835_fb: Silence Coverity warning about multiply overflow

Browse Source 
Coverity complains (CID 1395628) that the multiply in the calculation
of the framebuffer base is performed as 32x32 but then used in a
context that takes a 64-bit hwaddr. This can't actually ever
overflow the 32-bit result, because of the constraints placed on
the s->config values in bcm2835_fb_validate_config(). But we
can placate Coverity anyway, by explicitly casting one of the
inputs to a hwaddr, so the whole expression is calculated with
64-bit arithmetic.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20181005133012.26490-1-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2018-10-08 14:55:05 +01:00
parent 167765f073
commit 74e2e59b8d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/display/bcm2835_fb.c
View File

@ -190,7 +190,7 @@ static void fb_update_display(void *opaque)
} }
if (s->invalidate) { if (s->invalidate) {
hwaddr base = s->config.base + xoff + yoff * src_width; hwaddr base = s->config.base + xoff + (hwaddr)yoff * src_width;
framebuffer_update_memory_section(&s->fbsection, s->dma_mr, framebuffer_update_memory_section(&s->fbsection, s->dma_mr,
base, base,
s->config.yres, src_width); s->config.yres, src_width);