mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: Allocating Large sized arrays to heap

Browse Source 
nc_sendv_compat has a huge stack usage of 69680 bytes approx.
Moving large arrays to heap to reduce stack usage.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Pooja Dhannawat <dhannawatpooja1@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Pooja Dhannawat 2016-03-28 18:04:11 +05:30 committed by Jason Wang
parent a1555559ab
commit 74044c8ffc
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
net/net.c
View File

@ -683,23 +683,28 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const uint8_t *buf, int size)
static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov,
int iovcnt, unsigned flags) int iovcnt, unsigned flags)
{ {
uint8_t buf[NET_BUFSIZE]; uint8_t *buf = NULL;
uint8_t *buffer; uint8_t *buffer;
size_t offset; size_t offset;
ssize_t ret;
if (iovcnt == 1) { if (iovcnt == 1) {
buffer = iov[0].iov_base; buffer = iov[0].iov_base;
offset = iov[0].iov_len; offset = iov[0].iov_len;
} else { } else {
buf = g_new(uint8_t, NET_BUFSIZE);
buffer = buf; buffer = buf;
offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf)); offset = iov_to_buf(iov, iovcnt, 0, buf, NET_BUFSIZE);
} }
if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) { if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) {
return nc->info->receive_raw(nc, buffer, offset); ret = nc->info->receive_raw(nc, buffer, offset);
} else { } else {
return nc->info->receive(nc, buffer, offset); ret = nc->info->receive(nc, buffer, offset);
} }
g_free(buf);
return ret;
} }
ssize_t qemu_deliver_packet_iov(NetClientState *sender, ssize_t qemu_deliver_packet_iov(NetClientState *sender,