mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test-throttle: Simplify qemu_init_main_loop() error handling

Browse Source 
The code looks like it tries to check for both qemu_init_main_loop()
and qemu_get_aio_context() failure in one conditional.  In fact,
qemu_get_aio_context() can fail only after qemu_init_main_loop()
failed.

Simplify accordingly: check for qemu_init_main_loop() error directly,
without bothering to improve its error message.  Call
qemu_get_aio_context() only when qemu_get_aio_context() succeeded.  It
can't fail then, so no need to check.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1450452927-8346-9-git-send-email-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2015-12-18 16:35:11 +01:00
parent a4699e55f5
commit 73eaa04777
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/test-throttle.c
View File

@ -581,21 +581,8 @@ static void test_groups(void)
int main(int argc, char **argv)
{
Error *local_error = NULL;
qemu_init_main_loop(&local_error);
qemu_init_main_loop(&error_fatal);
ctx = qemu_get_aio_context();
if (!ctx) {
error_report("Failed to create AIO Context: '%s'",
local_error ? error_get_pretty(local_error) :
"Failed to initialize the QEMU main loop");
if (local_error) {
error_free(local_error);
}
exit(1);
}
bdrv_init();
do {} while (g_main_context_iteration(NULL, false));