mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/dma/pl330: Use qemu_hexdump_line to avoid sprintf

Browse Source 
sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1.
Using qemu_hexdump_line both fixes the deprecation warning and
simplifies the code base.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-Id: <20240412073346.458116-11-richard.henderson@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2024-04-12 00:33:29 -07:00 committed by Richard Henderson
parent 80e945894a
commit 7210ddb45f
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
hw/dma/pl330.c
View File

@ -15,6 +15,7 @@
*/ */
#include "qemu/osdep.h" #include "qemu/osdep.h"
#include "qemu/cutils.h"
#include "hw/irq.h" #include "hw/irq.h"
#include "hw/qdev-properties.h" #include "hw/qdev-properties.h"
#include "hw/sysbus.h" #include "hw/sysbus.h"
@ -317,22 +318,14 @@ typedef struct PL330InsnDesc {
static void pl330_hexdump(uint8_t *buf, size_t size) static void pl330_hexdump(uint8_t *buf, size_t size)
{ {
unsigned int b, i, len; g_autoptr(GString) str = g_string_sized_new(64);
char tmpbuf[80]; size_t b, len;
for (b = 0; b < size; b += 16) { for (b = 0; b < size; b += len) {
len = size - b; len = MIN(16, size - b);
if (len > 16) { g_string_truncate(str, 0);
len = 16; qemu_hexdump_line(str, buf + b, len, 1, 4);
} trace_pl330_hexdump(b, str->str);
tmpbuf[0] = '\0';
for (i = 0; i < len; i++) {
if ((i % 4) == 0) {
strcat(tmpbuf, " ");
}
sprintf(tmpbuf + strlen(tmpbuf), " %02x", buf[b + i]);
}
trace_pl330_hexdump(b, tmpbuf);
} }
} }